fix(localize): merge XLIFF translation file <file> elements
#35936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0e64522 to
7dff90c
Compare
AndrewKushnir
approved these changes
Mar 8, 2020
There was a problem hiding this comment.
LGTM, thanks for the fixes @petebacondarwin! 👍
Just left a couple minor nits, otherwise looks great.
...e/src/tools/src/translate/translation_files/translation_parsers/xliff1_translation_parser.ts
Outdated
Show resolved
Hide resolved
...tools/test/translate/translation_files/translation_parsers/xliff1_translation_parser_spec.ts
Outdated
Show resolved
Hide resolved
b695099 to
c6c88bd
Compare
XLIFF translation files can contain multiple `<file>` elements, each of which contains translations. In ViewEngine all these translations are merged into a single translation bundle. Previously in Ivy only the translations from the last `<file>` element were being loaded. Now all the translations from each `<file>` are merged into a single translation bundle. Fixes angular#35839
c6c88bd to
cd169fb
Compare
matsko
pushed a commit
that referenced
this pull request
Mar 9, 2020
…5936) XLIFF translation files can contain multiple `<file>` elements, each of which contains translations. In ViewEngine all these translations are merged into a single translation bundle. Previously in Ivy only the translations from the last `<file>` element were being loaded. Now all the translations from each `<file>` are merged into a single translation bundle. Fixes #35839 PR Close #35936
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35839
// FW-1980