Thanks to visit codestin.com
Credit goes to github.com

Skip to content

docs: clarifies the service limitation #36349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

docs: clarifies the service limitation #36349

wants to merge 3 commits into from

Conversation

sonukapoor
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #36332

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@ngbot ngbot bot added this to the needsTriage milestone Apr 1, 2020
@kapunahelewong kapunahelewong added effort1: hours target: patch This PR is targeted for the next patch release risk: low type: bug/fix labels Apr 9, 2020
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Apr 9, 2020
@ajitsinghkaler
Copy link
Contributor

@sonukapoor commit-msg is not correct please add fixes #36332 so that that issue closes automatically once this pull request closes

@sonukapoor
Copy link
Contributor Author

@pkozlowski-opensource Can you please review this?

aikithoughts
aikithoughts suggested changes Apr 23, 2020
View reviewed changes
aikithoughts
aikithoughts suggested changes Apr 23, 2020
View reviewed changes
@sonukapoor
Copy link
Contributor Author

@aikidave / @pkozlowski-opensource Any chance to get this merged?

@gkalpak gkalpak added the action: merge The PR is ready for merge by the caretaker label May 13, 2020
kara
kara approved these changes May 14, 2020
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara removed the request for review from pkozlowski-opensource May 14, 2020 18:59
kara pushed a commit that referenced this pull request May 14, 2020
@sonukapoor @kara
docs: clarifies the service limitation (#36349)
9259069 
Closes #36332

PR Close #36349
@kara kara closed this in 5f64e52 May 14, 2020
@sonukapoor sonukapoor deleted the patch-4 branch May 14, 2020 19:18
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 14, 2020
profanis pushed a commit to profanis/angular that referenced this pull request Sep 5, 2020
@sonukapoor @profanis
docs: clarifies the service limitation (angular#36349)
96fbb10 
Closes angular#36332

PR Close angular#36349
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@kara kara kara approved these changes

@aikithoughts aikithoughts aikithoughts approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours risk: low target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
7 participants
@sonukapoor @ajitsinghkaler @kara @aikithoughts @kapunahelewong @googlebot @gkalpak