Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(router): state data missing in routerLink #36462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix(router): state data missing in routerLink #36462

wants to merge 2 commits into from

Conversation

atscott
Copy link
Contributor

@atscott atscott commented Apr 6, 2020

fixes #33173 - router state data is missing on routerLink when used
with non-anchor elements.

@atscott atscott added type: bug/fix action: review The PR is still awaiting reviews from at least one requested reviewer area: router target: patch This PR is targeted for the next patch release labels Apr 6, 2020
@atscott atscott requested a review from AndrewKushnir April 6, 2020 21:19
@ngbot ngbot bot modified the milestone: needsTriage Apr 6, 2020
@atscott
fix(router): state data missing in routerLink
a3f6f7b 
fixes angular#33173 - router state data is missing on routerLink when used
with non-anchor elements.
AndrewKushnir
AndrewKushnir approved these changes Apr 6, 2020
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple nits 👍 Thanks @atscott.

@AndrewKushnir AndrewKushnir added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 6, 2020
@atscott
Copy link
Contributor Author

atscott commented Apr 6, 2020

presubmit

atscott
atscott commented Apr 6, 2020
View reviewed changes
Copy link
Contributor Author

@atscott atscott left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge assistance: I'm the owner of router and can't approve my own PR. Review from Andrew K should be enough.

@atscott atscott added merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Apr 6, 2020
@ngbot ngbot bot added the action: merge The PR is ready for merge by the caretaker label Apr 6, 2020
@atscott atscott mentioned this pull request Apr 6, 2020
Closed
14 tasks
@kara kara closed this in e0415db Apr 7, 2020
kara pushed a commit that referenced this pull request Apr 7, 2020
@atscott @kara
fix(router): state data missing in routerLink (#36462)
0e7a89a 
fixes #33173 - router state data is missing on routerLink when used
with non-anchor elements.

PR Close #36462
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: router cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

state input of RouterLink does not work
3 participants
@atscott @AndrewKushnir @googlebot