Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update Angular to support TS 3.9 #36989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 26 commits into from
Closed

Update Angular to support TS 3.9 #36989

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
708e1e3
build: pin @microsoft/api-extractor to 7.7.11
alan-agius4 May 12, 2020
96c5574
fix(language-service): use empty statement as parent of type node
May 12, 2020
6a66575
test(language-service): external template update should not invalidat…
May 12, 2020
67a4e51
build: prepare for TypeScript 3.9
alan-agius4 May 12, 2020
e5ca0be
refactor(ngcc): simplify the `detectKnownDeclaration()` signature
petebacondarwin May 12, 2020
605f6ae
refactor(compiler-cli): simplify and clarify `TypeScriptReflectionHos…
petebacondarwin May 12, 2020
dfd69b6
refactor(compiler-cli): delegate `hasBaseClass()` to `getBaseClassExp…
petebacondarwin May 12, 2020
1a6a71f
refactor(ngcc): remove unused import
petebacondarwin May 12, 2020
5949f3a
refactor(ngcc): ensure unlocker process works in mock file-systems
petebacondarwin May 12, 2020
e97dfd7
fix(ngcc): ensure reflection hosts can handle TS 3.9 IIFE wrapped cla…
petebacondarwin May 12, 2020
8657a24
fix(ngcc): ensure rendering formatters work with IIFE wrapped classes
petebacondarwin May 12, 2020
233ef52
test(ngcc): move specs to correct describe block
petebacondarwin May 12, 2020
50c1659
test(compiler-cli): hande TS 3.9 format in emisson tests
petebacondarwin May 12, 2020
f729a2c
test(ngcc): reformat some subject code for tests
petebacondarwin May 12, 2020
c7f7882
refactor(ngcc): rename `ReexportStatement` to `WildcardReexportStatem…
petebacondarwin May 12, 2020
57edd6b
docs(ngcc): tidy up typos etc in comments
petebacondarwin May 12, 2020
d202276
fix(ngcc): `viaModule` should be `null` for local imports
petebacondarwin May 12, 2020
b086ca9
fix(ngcc): support `defineProperty()` re-exports in CommonJS and UMD
petebacondarwin May 12, 2020
f6c0559
test(docs-infra): update payload sizes after TS 3.9 update
petebacondarwin May 12, 2020
7b455b1
fix(compiler-cli): compute the correct target output for `$localize` …
petebacondarwin May 12, 2020
8391ab8
test: update payload sizes after TS 3.9 update
alan-agius4 May 12, 2020
ade3796
test: enable importHelpers for UMD builds
alan-agius4 May 12, 2020
d0bf4b3
test: disable `cli-hello-world-lazy-rollup` from ivy tests
alan-agius4 May 12, 2020
5125158
refactor: `EventEmitter` to retain behaviour of pre TypeScript 3.9
alan-agius4 May 13, 2020
cabdb74
test: update language service module resolution cache
alan-agius4 May 13, 2020
d53f40e
build(docs-infra): correctly handle "pseudo" classes
petebacondarwin May 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: update language service module resolution cache 
With this change we update the expect of the `module resolution cache` were in the second count with cache the `fileExists` is called less then 700 times.
  • Loading branch information
@alan-agius4 @IgorMinar
alan-agius4 authored and IgorMinar committed May 14, 2020
commit cabdb74fbd009788287aebe8285ebb5d9f6c7c97
4 changes: 2 additions & 2 deletions packages/language-service/test/reflector_host_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,8 @@ describe('reflector_host_spec', () => {
// This resolves all Angular directives in the project.
ngLSHost.getAnalyzedModules();
const secondCount = spy.calls.count();
expect(secondCount).toBeGreaterThan(700);
expect(secondCount).toBeLessThan(800);
expect(secondCount).toBeGreaterThan(500);
expect(secondCount).toBeLessThan(600);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kyliau - it would be good to understand why these have changed...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aperently, in 3.9 TS improved file lookups.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is strange though that the lookups decreased after the event emitter changes.

spy.calls.reset();

// Third count is due to recompution after the program changes.
Expand Down