-
Notifications
You must be signed in to change notification settings - Fork 26.6k
fix(dev-infra): misc fixes for the compare master and patch script #37150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dev-infra): misc fixes for the compare master and patch script #37150
Conversation
This commit includes a couple minor fixes for the script that compares master and patch branch: - take only relevant release commit into account while generating the diff - fix the initial version display (avoid '+' sign from being added) - removes obsolete parameter that was needed for v9.0.x branch only
The new output looks good to me!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm after you resolve the comment about dropping the release notes commit.
Thanks for the review @IgorMinar 👍 |
…37150) This commit includes a couple minor fixes for the script that compares master and patch branch: - take only relevant release commit into account while generating the diff - fix the initial version display (avoid '+' sign from being added) - removes obsolete parameter that was needed for v9.0.x branch only PR Close #37150
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
…ngular#37150) This commit includes a couple minor fixes for the script that compares master and patch branch: - take only relevant release commit into account while generating the diff - fix the initial version display (avoid '+' sign from being added) - removes obsolete parameter that was needed for v9.0.x branch only PR Close angular#37150
This commit includes a couple minor fixes for the script that compares master and patch branch:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?