Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(service-worker): finish implementation of refreshAhead feature #53356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

yelhouti
Copy link
Contributor

@yelhouti yelhouti commented Dec 5, 2023

Copy and document the refreshAhead option that allows to refresh cache entries before they expire. This allows to mark cached entries as stale while still retruning them until maxAge in case of service outage.

Closes #46729

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #46729

What is the new behavior?

refreshAhead config is honored

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from alxhub December 5, 2023 10:26
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Dec 5, 2023
@yelhouti
Copy link
Contributor Author

yelhouti commented Dec 6, 2023

@gkalpak since you commented on the issue, would you be interested in checking this ?

@dylhunn dylhunn added the area: service-worker Issues related to the @angular/service-worker package label Dec 6, 2023
@ngbot ngbot bot added this to the Backlog milestone Dec 6, 2023
@thePunderWoman thePunderWoman added the action: review The PR is still awaiting reviews from at least one requested reviewer label Oct 9, 2024
@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release PullApprove: disable and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 9, 2024
@thePunderWoman thePunderWoman removed the request for review from alxhub October 9, 2024 15:30
Copy and document the refreshAhead option that allows to refresh cache entries before they expire.
This allows to mark cached entries as stale while still retruning them until maxAge in case of service outage.

Closes angular#46729
@devversion
Copy link
Member

This PR was merged into the repository by commit 1479af9.

The changes were merged into the following branches: main

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: service-worker Issues related to the @angular/service-worker package detected: feature PR contains a feature commit PullApprove: disable target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refreshAheadMs missing on serviceWorker config
5 participants