Thanks to visit codestin.com
Credit goes to github.com

Skip to content

docs: editor README #53763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

leoortizz
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe: Docs for editor, see https://github.com/angular/blossom/pull/975

What is the current behavior?

Issue Number: N/A

What is the new behavior?

editor now have a README 😊

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from josephperrott January 2, 2024 21:50

## Notes

- See [scripts/tutorials/README.md](/scripts/tutorials/README.md) for more information about the tutorials script.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@josephperrott Not sure where to link this to or if we just remove it? I think you were migrating it from Node to Bazel so the docs might need be rewritten too. It's originally here: https://github.com/angular/blossom/blob/main/scripts/tutorials/README.md

@leoortizz leoortizz force-pushed the embeddedEditorReadme branch from fd1c262 to 788195c Compare January 2, 2024 22:04
@leoortizz leoortizz changed the title editor README docs: editor README Jan 2, 2024
@angular-robot angular-robot bot added the area: docs Related to the documentation label Jan 2, 2024
@ngbot ngbot bot added this to the Backlog milestone Jan 2, 2024
@AndrewKushnir AndrewKushnir self-requested a review January 2, 2024 22:11
@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jan 2, 2024
Copy link
Contributor

@danieljancar danieljancar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🦖

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 6, 2024
@AndrewKushnir AndrewKushnir removed the request for review from josephperrott March 6, 2024 22:33
@atscott
Copy link
Contributor

atscott commented Mar 7, 2024

This PR was merged into the repository by commit 8bf842d.

atscott pushed a commit that referenced this pull request Mar 7, 2024
atscott pushed a commit that referenced this pull request Mar 7, 2024
@atscott atscott closed this in 30dccd4 Mar 7, 2024
atscott pushed a commit that referenced this pull request Mar 7, 2024
atscott pushed a commit that referenced this pull request Mar 7, 2024
atscott pushed a commit that referenced this pull request Mar 7, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants