Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor(core): refactor i18n node creation to prepare for hydration #54722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

refactor(core): refactor i18n node creation to prepare for hydration #54722

wants to merge 1 commit into from

Conversation

devknoll
Copy link
Contributor

@devknoll devknoll commented Mar 6, 2024 •
edited
Loading

Adds a locateOrCreateNode helper and uses it for all DOM operations in preparation for supporting hydration.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@devknoll
refactor(core): refactor i18n node creation to prepare for hydration
9125ff8 
Adds a `locateOrCreateNode` helper and uses it for all DOM operations in preparation for supporting hydration.
@pullapprove pullapprove bot requested review from devversion and dgp1130 March 6, 2024 16:08
@devknoll
Copy link
Contributor Author

devknoll commented Mar 6, 2024

cc @AndrewKushnir

AndrewKushnir
AndrewKushnir approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the refactor 👍

@AndrewKushnir AndrewKushnir added area: i18n Issues related to localization and internationalization target: patch This PR is targeted for the next patch release action: presubmit The PR is in need of a google3 presubmit labels Mar 6, 2024
@ngbot ngbot bot added this to the Backlog milestone Mar 6, 2024
@AndrewKushnir
Copy link
Contributor

Presubmit.

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: presubmit The PR is in need of a google3 presubmit labels Mar 6, 2024
atscott pushed a commit that referenced this pull request Mar 7, 2024
@devknoll @atscott
refactor(core): refactor i18n node creation to prepare for hydration (#…
b9a0d02 
…54722)

Adds a `locateOrCreateNode` helper and uses it for all DOM operations in preparation for supporting hydration.

PR Close #54722
@atscott
Copy link
Contributor

atscott commented Mar 7, 2024

This PR was merged into the repository by commit 43ab781.

@atscott atscott closed this in 43ab781 Mar 7, 2024
atscott pushed a commit that referenced this pull request Mar 7, 2024
@devknoll @atscott
refactor(core): refactor i18n node creation to prepare for hydration (#…
0daa1ea 
…54722)

Adds a `locateOrCreateNode` helper and uses it for all DOM operations in preparation for supporting hydration.

PR Close #54722
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 7, 2024
@devknoll devknoll deleted the x-i18n-apply-refactor branch April 11, 2024 17:59
henry-alakazhang pushed a commit to freelancer/angular that referenced this pull request Jun 19, 2024
@devknoll @henry-alakazhang
refactor(core): refactor i18n node creation to prepare for hydration (a…
0c3b42e 
…ngular#54722)

Adds a `locateOrCreateNode` helper and uses it for all DOM operations in preparation for supporting hydration.

PR Close angular#54722
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: i18n Issues related to localization and internationalization target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
3 participants
@devknoll @AndrewKushnir @atscott