refactor(core): don't hydrate detached nodes #54723
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for hydration support, make sure that we don't attempt to hydrate detached nodes and instead, always newly create them.
1e8789a to
12c4d67
Compare
AndrewKushnir
approved these changes
Mar 6, 2024
|
This PR was merged into the repository by commit e0c1f1e. |
atscott
pushed a commit
that referenced
this pull request
Mar 7, 2024
In preparation for hydration support, make sure that we don't attempt to hydrate detached nodes and instead, always newly create them. PR Close #54723
atscott
pushed a commit
that referenced
this pull request
Mar 7, 2024
In preparation for hydration support, make sure that we don't attempt to hydrate detached nodes and instead, always newly create them. PR Close #54723
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
henry-alakazhang
pushed a commit
to freelancer/angular
that referenced
this pull request
Jun 19, 2024
In preparation for hydration support, make sure that we don't attempt to hydrate detached nodes and instead, always newly create them. PR Close angular#54723
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for hydration support, make sure that we don't attempt to hydrate detached nodes and instead, always newly create them.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information