docs: adding signal inputs and model to ADEV. #54753
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed adev-preview for de22389 to: https://ng-dev-previews-fw--pr-angular-angular-54753-adev-prev-kfdxxac0.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
twerske
reviewed
Mar 7, 2024
Comment on lines
6
to
10
| <div class="alert is-helpful"> | ||
|
|
||
| Signal inputs are currently in [developer preview](/guide/releases#developer-preview). | ||
|
|
||
| </div> |
There was a problem hiding this comment.
These need to be converted to the correct syntax
twerske
reviewed
Mar 7, 2024
Comment on lines
138
to
144
| <div class="alert is-important"> | ||
|
|
||
| Do not use transforms if they change the meaning of the input, or if they are [impure](https://en.wikipedia.org/wiki/Pure_function#Impure_functions). | ||
|
|
||
| Instead, use `computed` for transformations with different meaning, or an `effect` for impure code that should run whenever the input changes. | ||
|
|
||
| </div> |
twerske
reviewed
Mar 7, 2024
Comment on lines
6
to
8
| <div class="alert is-helpful"> | ||
|
|
||
| Model inputs are currently in [developer preview](/guide/releases#developer-preview). | ||
|
|
||
| </div> |
twerske
reviewed
Mar 7, 2024
816013d to
3ea94c9
Compare
twerske
reviewed
Mar 8, 2024
|
|
||
| HELPFUL: Model inputs are currently in [developer preview](/guide/releases#developer-preview). | ||
|
|
||
| </div> |
|
Feel free to move this to a non-draft PR and after the one fix this can be marked for merge! |
twerske
approved these changes
Mar 8, 2024
Those docs are a copy from AIO.
3ea94c9 to
de22389
Compare
twerske
approved these changes
Mar 11, 2024
atscott
pushed a commit
that referenced
this pull request
Mar 11, 2024
Those docs are a copy from AIO. PR Close #54753
atscott
pushed a commit
that referenced
this pull request
Mar 11, 2024
Those docs are a copy from AIO. PR Close #54753
|
This PR was merged into the repository by commit 09a2f3d. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those docs are a copy from AIO.
Direct link: https://ng-dev-previews-fw--pr-angular-angular-54753-adev-prev-kfdxxac0.web.app/guide/signals