Thanks to visit codestin.com
Credit goes to github.com

Skip to content

docs: fix repeated note in "Add an Input to the component" section #55306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

docs: fix repeated note in "Add an Input to the component" section #55306

wants to merge 1 commit into from

Conversation

MoIbrahim10
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from crisbeto April 11, 2024 18:13
@angular-robot angular-robot bot added the area: docs Related to the documentation label Apr 11, 2024
@ngbot ngbot bot added this to the Backlog milestone Apr 11, 2024
@JeanMeche JeanMeche added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Apr 11, 2024
@JeanMeche
Copy link
Member

Hi, thank you for the change. Could you please reword the commit and drop the routing scope. We're fine here without any scope. Thank you.

@MoIbrahim10 MoIbrahim10 changed the title docs(routing): fix repeated note in "Add an Input to the component" section docs: fix repeated note in "Add an Input to the component" section Apr 11, 2024
@MoIbrahim10
Copy link
Contributor Author

Hi, thank you for the change. Could you please reword the commit and drop the routing scope. We're fine here without any scope. Thank you.

Done 👍

sonukapoor
sonukapoor approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@sonukapoor sonukapoor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MoIbrahim10 It's in the commit message. Can you amend that?

@MoIbrahim10
Copy link
Contributor Author

@MoIbrahim10 It's in the commit message. Can you amend that?

sorry, i haven't notice.
i did now

@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Apr 12, 2024
@JeanMeche
Copy link
Member

Thank you for this !

@atscott atscott added the target: patch This PR is targeted for the next patch release label Apr 12, 2024
@atscott
Copy link
Contributor

atscott commented Apr 12, 2024

This PR was merged into the repository by commit f947dd5.

@atscott atscott closed this in f947dd5 Apr 12, 2024
atscott pushed a commit that referenced this pull request Apr 12, 2024
@MoIbrahim10 @atscott
docs: fix repeated note in "Add an Input to the component" section (#…
a3b1dc0 
…55306)

PR Close #55306
iteriani pushed a commit to iteriani/angular that referenced this pull request Apr 16, 2024
@MoIbrahim10 @iteriani
docs: fix repeated note in "Add an Input to the component" section (a…
ef77686 
…ngular#55306)

PR Close angular#55306
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sonukapoor sonukapoor sonukapoor approved these changes

@JeanMeche JeanMeche JeanMeche approved these changes

@crisbeto crisbeto crisbeto approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
5 participants
@MoIbrahim10 @JeanMeche @atscott @sonukapoor @crisbeto