fix(core): added @angular/compiler as a peer dependency #55610
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
alan-agius4
reviewed
May 2, 2024
alan-agius4
approved these changes
May 2, 2024
alxhub
approved these changes
Mar 4, 2025
This fixes an issue with packages managers likes pmpm that will not link the @angular/compiler package to the @angular/core package if it is not listed as a peer dependency. I added it as optional peer dependency as it's only used in special cases. Fixes angular#38096
|
This PR was merged into the repository by commit 7eb59d3. The changes were merged into the following branches: main |
alexeagle
added a commit
to aspect-build/bazel-examples
that referenced
this pull request
Mar 27, 2025
alexeagle
added a commit
to aspect-build/bazel-examples
that referenced
this pull request
Mar 28, 2025
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with packages managers likes pmpm that will not link the @angular/compiler package to the @angular/core package if it is not listed as a peer dependency.
I added it as optional peer dependency as it's only used in special cases.
Fixes #38096
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Today @angular/core/testing is using @angular/compiler without specifying it as a dependency.
This results in strict package managers like pnpm don't find the dependency.
Issue Number: #38096
What is the new behavior?
@angular/compiler is added as an optional peerDependency for @angular/core
Does this PR introduce a breaking change?
Other information