fix(http): resolve withRequestsMadeViaParent behavior with withFetch
#55652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
commented
May 3, 2024
| @@ -294,26 +298,13 @@ export function withRequestsMadeViaParent(): HttpFeature<HttpFeatureKind.Request | |||
| /** | |||
| * Configures the current `HttpClient` instance to make requests using the fetch API. | |||
| * | |||
| * This `FetchBackend` requires the support of the Fetch API which is available on all evergreen | |||
There was a problem hiding this comment.
These are no longer needed as with v18 all versions of Node.js support fetch
14 tasks
This commit addresses dependency injection defects when using the `withFetch` API. Formerly, utilizing `withFetch` led to the automatic setting of `HttpBackend` to `FetchBackend`, which proved problematic in certain scenarios. Notably, conflicts arose when integrating `withRequestsMadeViaParent` and manually overriding tokens, as observed in instances like `InMemoryWebApiModule`.
JeanMeche
reviewed
May 3, 2024
AndrewKushnir
approved these changes
May 4, 2024
JeanMeche
approved these changes
May 4, 2024
|
This PR was merged into the repository by commit 9ddb003. |
AndrewKushnir
pushed a commit
that referenced
this pull request
May 6, 2024
…ch` (#55652) This commit addresses dependency injection defects when using the `withFetch` API. Formerly, utilizing `withFetch` led to the automatic setting of `HttpBackend` to `FetchBackend`, which proved problematic in certain scenarios. Notably, conflicts arose when integrating `withRequestsMadeViaParent` and manually overriding tokens, as observed in instances like `InMemoryWebApiModule`. PR Close #55652
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses dependency injection defects when using the
withFetchAPI. Formerly, utilizingwithFetchled to the automatic setting ofHttpBackendtoFetchBackend, which proved problematic in certain scenarios. Notably, conflicts arose when integratingwithRequestsMadeViaParentand manually overriding tokens, as observed in instances likeInMemoryWebApiModule.Reviewer note: I suggest that you enable
hide whitespace.