-
Notifications
You must be signed in to change notification settings - Fork 26.3k
refactor(core): WIP - partial hydration prototype #56311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
thePunderWoman
wants to merge
19
commits into
angular:main
from
thePunderWoman:partial-hydration-prototype
Closed
refactor(core): WIP - partial hydration prototype #56311
thePunderWoman
wants to merge
19
commits into
angular:main
from
thePunderWoman:partial-hydration-prototype
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5cd9091
to
7a8fb19
Compare
7a8fb19
to
ed9fa93
Compare
4eaaad5
to
d532715
Compare
57c97e3
to
43320ca
Compare
065d394
to
056f50c
Compare
This separates out the full app hydration and partial hydration tests, adds a bunch, and adds ngh annotations for defer blocks.
Lets test it out! It WORKS! IT WORKS!
this adds serialized defer block details for partial hydration
This should be able to look through and find all the nodes with ngh and the appropriate triggers for partial hydration.
This adds non-jsaction events and starts to get them working
This adds functionality for all the partial hydration triggers.
This adds a never hydrate trigger.
this ensures the injection of the partial hydration token is optional and defaults to false.
this adds hydrate cleanup to trigger cleanup invocation.
defer triggers would be called regardless of the hydrate trigger presence. This ensures they are not called when on initial load and have a hydrate flag.
Partial hydration cases are nuanced in when they need to be cleaned up. This adds the right conditions to avoid over and under cleaning up of nodes.
Hydrate viewport will always be adjacent to a defer trigger. So hydrate triggers should never cause a missing placeholder error to occur.
In some cases, hydrate triggers were being used as a default due to a problem in the ingest parsing. This ensures idle is added as default in the right cases.
event replay was firing too early in some cases due to an early return of a null.
cleanup was causing overzealous removal of content because the app was not yet stable.
58f6b26
to
1ceaaca
Compare
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area: compiler
Issues related to `ngc`, Angular's template compiler
area: core
Issues related to the framework runtime
detected: feature
PR contains a feature commit
state: WIP
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.