Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor(core): remove unused function in signal code #56765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

refactor(core): remove unused function in signal code #56765

wants to merge 1 commit into from

Conversation

cexbrayat
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

It looks like it was introduced at the very beginning but never actually used.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested review from alxhub and jatraman June 29, 2024 14:52
@pullapprove pullapprove bot added the requires: TGP This PR requires a passing TGP before merging is allowed label Jun 29, 2024
@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Jun 29, 2024
@ngbot ngbot bot added this to the Backlog milestone Jun 29, 2024
@cexbrayat cexbrayat force-pushed the refactor/unused-signal-code branch from 422e738 to 6126171 Compare September 26, 2024 14:28
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Sep 26, 2024
@ngbot ngbot bot modified the milestone: Backlog Sep 26, 2024
@alxhub alxhub added action: merge The PR is ready for merge by the caretaker and removed requires: TGP This PR requires a passing TGP before merging is allowed labels Sep 26, 2024
@pullapprove pullapprove bot added the requires: TGP This PR requires a passing TGP before merging is allowed label Sep 26, 2024
@devversion devversion added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: merge The PR is ready for merge by the caretaker labels Oct 1, 2024
@devversion
Copy link
Member

@alxhub please review. Not sure if the label add is intentional.

@pullapprove pullapprove bot requested a review from Jesse-Good October 30, 2024 20:23
@pullapprove pullapprove bot requested a review from Jesse-Good October 30, 2024 20:31
@cexbrayat
refactor(core): remove unused function in signal code
bca2961 
It looks like it was introduced at the very beginning but never actually used.
@cexbrayat cexbrayat force-pushed the refactor/unused-signal-code branch from 6126171 to bca2961 Compare January 21, 2025 08:34
@pullapprove pullapprove bot requested a review from iteriani January 21, 2025 08:34
@JeanMeche
Copy link
Member

#60497 will introduce an export.

@JeanMeche JeanMeche closed this Mar 31, 2025
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alxhub alxhub Awaiting requested review from alxhub

@jatraman jatraman Awaiting requested review from jatraman

@Jesse-Good Jesse-Good Awaiting requested review from Jesse-Good

@iteriani iteriani Awaiting requested review from iteriani

Assignees
No one assigned
Labels
action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime requires: TGP This PR requires a passing TGP before merging is allowed
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
5 participants
@cexbrayat @devversion @JeanMeche @Jesse-Good @alxhub