fix(upgrade): fixes downgrade issue for signal based inputs #56837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue where setting inputs did not work if the component used signal based inputs resulting in errors. Switching to `setInput` API will correctly set the inputs.
|
Oh wait, actually, this is about update, not elements 🤦 Re-opening. This PR would require tests to land, though. |
|
Took a look and turns out this may require more changes than anticipated. Closing this PR and will file a bug. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue where setting inputs did not work if the component used signal based inputs resulting in errors.
Switching to
setInputAPI will correctly set the inputs.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Signal based inputs get the raw value instead of the signal function causing
not a functionerror.Issue Number: N/A
What is the new behavior?
Using
setInputcorrectly sets the input on the component. If the input is signal based then it wraps the value in the signal prior to setting it in the component.Does this PR introduce a breaking change?
Other information