Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(router): Update Resolve interface to include RedirectCommand like… #57309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

atscott
Copy link
Contributor

@atscott atscott commented Aug 8, 2024

… ResolveFn

This commit updates the interface of Resolve to allow for RedirectCommand, as was done with ResolveFn in v18.

fixes #57131

BREAKING CHANGE: The return type of the Resolve interface now includes RedirectCommand.

… ResolveFn

This commit updates the interface of `Resolve` to allow for
`RedirectCommand`, as was done with `ResolveFn` in v18.

fixes angular#57131

BREAKING CHANGE: The return type of the `Resolve` interface now includes
`RedirectCommand`.
@atscott atscott added area: router target: major This PR is targeted for the next major release labels Aug 8, 2024
@ngbot ngbot bot added this to the Backlog milestone Aug 8, 2024
@angular-robot angular-robot bot added the detected: breaking change PR contains a commit with a breaking change label Aug 8, 2024
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

reviewed-for: public-api

@pullapprove pullapprove bot requested a review from AndrewKushnir August 8, 2024 16:44
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api, fw-router

@atscott atscott added the action: merge The PR is ready for merge by the caretaker label Aug 8, 2024
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 7436d31.

The changes were merged into the following branches: main

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: router detected: breaking change PR contains a commit with a breaking change target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Resolve implementations to return RedirectCommand
4 participants