Transform logic to extract signal debug names #57348
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgp1130
reviewed
Aug 12, 2024
packages/compiler-cli/src/ngtsc/annotations/directive/src/input_output_parse_options.ts
Outdated
Show resolved
Hide resolved
packages/compiler-cli/src/ngtsc/transform/src/debug_transform.ts
Outdated
Show resolved
Hide resolved
packages/compiler-cli/src/ngtsc/transform/src/debug_transform.ts
Outdated
Show resolved
Hide resolved
packages/compiler-cli/src/ngtsc/annotations/directive/src/input_output_parse_options.ts
Outdated
Show resolved
Hide resolved
packages/compiler-cli/src/ngtsc/transform/src/debug_transform.ts
Outdated
Show resolved
Hide resolved
packages/compiler-cli/src/ngtsc/transform/src/debug_transform.ts
Outdated
Show resolved
Hide resolved
packages/compiler-cli/src/ngtsc/transform/src/debug_transform.ts
Outdated
Show resolved
Hide resolved
packages/compiler-cli/src/ngtsc/transform/src/debug_transform.ts
Outdated
Show resolved
Hide resolved
c3d0bf5 to
fbbc8c0
Compare
devversion
reviewed
Aug 26, 2024
packages/compiler-cli/src/ngtsc/annotations/directive/src/input_output_parse_options.ts
Outdated
Show resolved
Hide resolved
alxhub
reviewed
Sep 24, 2024
There was a problem hiding this comment.
First round of comments!
Additionally, in the commit history, use refactor commits for implementation details. A given feature (debug names for example) should have exactly 1 feat commit, which is the commit which actually makes the feature available for end users to use.
packages/compiler-cli/src/ngtsc/annotations/directive/src/input_output_parse_options.ts
Outdated
Show resolved
Hide resolved
packages/compiler-cli/src/ngtsc/transform/src/implicit_signal_debug_name_transform.ts
Outdated
Show resolved
Hide resolved
packages/compiler-cli/src/ngtsc/transform/src/implicit_signal_debug_name_transform.ts
Outdated
Show resolved
Hide resolved
| ]), | ||
| undefined, | ||
| ts.factory.createArrayLiteralExpression([ | ||
| ts.factory.createObjectLiteralExpression(existingArgument.properties), |
There was a problem hiding this comment.
Same comment about ts.factory.update*.
There was a problem hiding this comment.
This is still a bit sketchy to me. This creates a node without any context (e.g. sourcemaps).
Ideally, we wouldn't have to copy the user's code like this, but we should still use ts.update* instead.
There was a problem hiding this comment.
We discussed this briefly in the DevTools sync today. We can definitely update this object literal to just be existingArgument. How should this work for the duplicated node though?
We're effectively converting signal(0, { equals }) to signal(0, ...(ngDevMode ? [{ debugName: 'test', equals }] : [{ equals }])). That moves { equals } to the false case, but also duplicate its in the true case. I presume we just need to ts.factory.create*(...) for the true case and can't update the existing one because we need it for the false case?
There was a problem hiding this comment.
Tested over the weekend with ng new and the compiler cli code with the transform. Source maps are working as expected even with the transformation applied. I think this is working as expected now
dgp1130
reviewed
Oct 18, 2024
packages/compiler-cli/src/ngtsc/transform/src/implicit_signal_debug_name_transform.ts
Outdated
Show resolved
Hide resolved
packages/compiler-cli/src/ngtsc/transform/src/implicit_signal_debug_name_transform.ts
Outdated
Show resolved
Hide resolved
packages/compiler-cli/src/ngtsc/transform/src/implicit_signal_debug_name_transform.ts
Outdated
Show resolved
Hide resolved
packages/compiler-cli/src/ngtsc/transform/src/implicit_signal_debug_name_transform.ts
Show resolved
Hide resolved
packages/compiler-cli/src/ngtsc/transform/src/implicit_signal_debug_name_transform.ts
Show resolved
Hide resolved
packages/compiler-cli/src/ngtsc/transform/src/implicit_signal_debug_name_transform.ts
Show resolved
Hide resolved
packages/compiler-cli/src/ngtsc/transform/src/implicit_signal_debug_name_transform.ts
Outdated
Show resolved
Hide resolved
packages/compiler-cli/src/ngtsc/transform/src/implicit_signal_debug_name_transform.ts
Outdated
Show resolved
Hide resolved
252d2cd to
5f59f91
Compare
af1f967 to
f05cdea
Compare
f05cdea to
780dab1
Compare
780dab1 to
6c5f302
Compare
f034848 to
52c3eb0
Compare
52c3eb0 to
e8acd3f
Compare
ad1b0ad to
57eaa4e
Compare
|
TGP still looking good: http://test/OCL:758440362:BASE:758744767:1747244383957:e4a093db |
0a905d2 to
a4a24df
Compare
66dee1d to
909a547
Compare
dgp1130
approved these changes
May 22, 2025
909a547 to
1b129b3
Compare
alxhub
approved these changes
Jun 2, 2025
1b129b3 to
a97f7fb
Compare
…om signal functions Implements a compiler transform that attempts to statically analyze variable names and apply them to usages of signal functions like signal, computed, effect, etc.
a97f7fb to
b7c9b39
Compare
|
This PR was merged into the repository by commit 3a9a70d. The changes were merged into the following branches: main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a compiler transform that attempts to statically analyze variable names and apply them to usages of signal functions like signal, computed, effect, etc as debug names.
Related: #57074
Depends on: #57073