refactor(migrations): ensure control flow analysis of signal input migration works with all TS versions #57566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2145abf to
37e5137
Compare
crisbeto
approved these changes
Aug 28, 2024
| @@ -14,8 +14,7 @@ class MyComp { | |||
|
|
|||
| it('should work', () => { | |||
| const inputs = { | |||
| hello: 'Damn', | |||
packages/core/schematics/migrations/signal-migration/test/ts-versions/package.json
Outdated
Show resolved
Hide resolved
Cleans up remaining TODOs in the signal input migration, and other small clean ups.
37e5137 to
9895be2
Compare
|
Caretaker note: presubmit is "green". |
…gration works with all TS versions Ensures that the control flow analysis version of the signal input works with all TS versions currently supported.
9895be2 to
9de177b
Compare
|
This PR was merged into the repository by commit 6e28f96. The changes were merged into the following branches: main, 18.2.x |
AndrewKushnir
pushed a commit
that referenced
this pull request
Aug 29, 2024
Cleans up remaining TODOs in the signal input migration, and other small clean ups. PR Close #57566
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.