Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Detect and remove complete calls for migrated outputs #57671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Detect and remove complete calls for migrated outputs #57671

wants to merge 2 commits into from

Conversation

pkozlowski-opensource
Copy link
Member

No description provided.

@pkozlowski-opensource
test(migrations): add more tests to output migration
f8f5649 
This change contains an additonal test that captures scenario
of the problematic .pipe usage outside of the directive class.
@pkozlowski-opensource
feat(migrations): remove complete calls for migrated outputs
84fd074 
This change removes superflous .complete calls for the migrated outputs.
@pullapprove pullapprove bot requested a review from crisbeto September 5, 2024 10:24
@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: migrations Issues related to `ng update` migrations labels Sep 5, 2024
@ngbot ngbot bot added this to the Backlog milestone Sep 5, 2024
@pkozlowski-opensource pkozlowski-opensource added the action: review The PR is still awaiting reviews from at least one requested reviewer label Sep 5, 2024
devversion
devversion approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean. lgtm!

@pkozlowski-opensource pkozlowski-opensource removed the request for review from crisbeto September 5, 2024 13:33
@pkozlowski-opensource pkozlowski-opensource added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 5, 2024
@thePunderWoman thePunderWoman added the action: presubmit The PR is in need of a google3 presubmit label Sep 5, 2024
thePunderWoman pushed a commit that referenced this pull request Sep 5, 2024
@pkozlowski-opensource @thePunderWoman
feat(migrations): remove complete calls for migrated outputs (#57671)
68e5370 
This change removes superflous .complete calls for the migrated outputs.

PR Close #57671
@thePunderWoman
Copy link
Contributor

This PR was merged into the repository by commit 68e5370.

The changes were merged into the following branches: main

@thePunderWoman thePunderWoman removed the action: presubmit The PR is in need of a google3 presubmit label Sep 5, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@azimtechie azimtechie azimtechie approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: migrations Issues related to `ng update` migrations detected: feature PR contains a feature commit target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
4 participants
@pkozlowski-opensource @thePunderWoman @devversion @azimtechie