Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor(core): introduce debugName optional arg to ReactiveNode #57710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

refactor(core): introduce debugName optional arg to ReactiveNode #57710

wants to merge 1 commit into from

Conversation

AleksanderBodurri
Copy link
Member

This commit contains the changes to core/primitives that used to be in #57073 but were moved for g3sync

@pullapprove pullapprove bot added the requires: TGP This PR requires a passing TGP before merging is allowed label Sep 7, 2024
@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: core Issues related to the framework runtime labels Sep 7, 2024
@ngbot ngbot bot added this to the Backlog milestone Sep 7, 2024
@AleksanderBodurri AleksanderBodurri force-pushed the signal-function-debug-names-primitive branch from 7a28bf4 to 7c91874 Compare September 10, 2024 22:05
@AleksanderBodurri AleksanderBodurri mentioned this pull request Sep 12, 2024
Closed
@AleksanderBodurri AleksanderBodurri added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed action: merge The PR is ready for merge by the caretaker labels Sep 20, 2024
@AleksanderBodurri
Copy link
Member Author

Awaiting g3sync run @alxhub

@AleksanderBodurri AleksanderBodurri added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Sep 23, 2024
alxhub
alxhub approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@alxhub alxhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just needs a change to the commit message to use refactor(core) instead of feat(core), because this is not a user visible feature.

@alxhub alxhub added merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed requires: TGP This PR requires a passing TGP before merging is allowed labels Sep 24, 2024
@pullapprove pullapprove bot added the requires: TGP This PR requires a passing TGP before merging is allowed label Sep 24, 2024
@alxhub
Copy link
Member

alxhub commented Sep 24, 2024

Caretaker: TGP not required (type-only change, can't affect production)

@AleksanderBodurri AleksanderBodurri force-pushed the signal-function-debug-names-primitive branch from 7c91874 to 6fee943 Compare September 27, 2024 00:04
@AleksanderBodurri AleksanderBodurri changed the title feat(core): introduce debugName optional arg to ReactiveNode refactor(core): introduce debugName optional arg to ReactiveNode Sep 27, 2024
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed detected: feature PR contains a feature commit area: core Issues related to the framework runtime labels Sep 27, 2024
@ngbot ngbot bot modified the milestone: Backlog Sep 27, 2024
@AleksanderBodurri AleksanderBodurri added the action: merge The PR is ready for merge by the caretaker label Oct 2, 2024
@pullapprove pullapprove bot removed the request for review from atscott October 2, 2024 21:00
@AleksanderBodurri AleksanderBodurri removed the action: merge The PR is ready for merge by the caretaker label Oct 2, 2024
@AleksanderBodurri
refactor(core): introduce debugName optional arg to ReactiveNode
f6813b3 
This commit contains the changes to core/primitives that used to be in angular#57073.
@AleksanderBodurri AleksanderBodurri force-pushed the signal-function-debug-names-primitive branch from 6fee943 to f6813b3 Compare October 2, 2024 21:08
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Oct 2, 2024
@AleksanderBodurri AleksanderBodurri added the action: merge The PR is ready for merge by the caretaker label Oct 2, 2024
AndrewKushnir
AndrewKushnir approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@AndrewKushnir
Copy link
Contributor

TESTED=No TGP required, see #57710 (comment).

@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 837af44.

The changes were merged into the following branches: main

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dgp1130 dgp1130 dgp1130 approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

@pkozlowski-opensource pkozlowski-opensource Awaiting requested review from pkozlowski-opensource

@tbondwilkinson tbondwilkinson Awaiting requested review from tbondwilkinson

@alxhub alxhub Awaiting requested review from alxhub

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note requires: TGP This PR requires a passing TGP before merging is allowed target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
4 participants
@AleksanderBodurri @alxhub @AndrewKushnir @dgp1130