feat(migrations): introduce signal input migration as ng generate schematic #57805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4665ff5 to
9c55f91
Compare
pweyrich
reviewed
Sep 13, 2024
packages/core/schematics/ng-generate/signal-input-migration/README.md
Outdated
Show resolved
Hide resolved
…sconfig Whenever the `ngc` binary is used directly to parse configurations, we should try to respect the configured file system like we do in all other places. Right now one spot where we escape the FS is for reading directories to e.g. support tsconfig#includes. This commit fixes this, implementing TypeScript's read directory method leveraging the configured FS. The approach taken here was used for a couple of months/years for Angular Material migrations and no issues were found.
…chematic Introduces a new `ng generate` schematic for migration `@Input()` declarations to signal inputs. This migration is the same that is also integrated into the VSCode extension. Note: In a follow-up the documentation for this will be improved, and a flag to report reasons on why certain inputs weren't migrated, is added.
7192520 to
d0bd242
Compare
crisbeto
approved these changes
Sep 13, 2024
…rsing tsconfig Improve message
pkozlowski-opensource
approved these changes
Sep 16, 2024
alan-agius4
approved these changes
Sep 16, 2024
atscott
approved these changes
Sep 16, 2024
|
This PR was merged into the repository by commit 59fe9bc. The changes were merged into the following branches: main |
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Sep 16, 2024
…chematic (#57805) Introduces a new `ng generate` schematic for migration `@Input()` declarations to signal inputs. This migration is the same that is also integrated into the VSCode extension. Note: In a follow-up the documentation for this will be improved, and a flag to report reasons on why certain inputs weren't migrated, is added. PR Close #57805
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new
ng generateschematic for migration@Input()declarations to signal inputs.
This migration is the same that is also integrated into the
VSCode extension.
Note: In a follow-up the documentation for this will be improved, and a
flag to report reasons on why certain inputs weren't migrated, is added.