Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(language-service): The suppress diagnostics option should work for external templates #57873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dylhunn
Copy link
Contributor

@dylhunn dylhunn commented Sep 18, 2024

Previously, due to a bug, this option only worked for inline templates.

@dylhunn dylhunn added action: review The PR is still awaiting reviews from at least one requested reviewer area: language-service Issues related to Angular's VS Code language service target: minor This PR is targeted for the next minor release labels Sep 18, 2024
@dylhunn dylhunn requested a review from atscott September 18, 2024 21:28
@dylhunn dylhunn added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 20, 2024
@ngbot ngbot bot added this to the Backlog milestone Sep 20, 2024
…r external templates

Previously, due to a bug, this option only worked for inline templates.
@dylhunn
Copy link
Contributor Author

dylhunn commented Sep 23, 2024

Caretaker: TAP Presubmit was green.

@dylhunn dylhunn added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Sep 23, 2024
@pkozlowski-opensource
Copy link
Member

This PR was merged into the repository by commit 7ecfd89.

The changes were merged into the following branches: main

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: language-service Issues related to Angular's VS Code language service merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants