Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Api signal queries stable #57921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Api signal queries stable #57921

wants to merge 2 commits into from

Conversation

pkozlowski-opensource
Copy link
Member

No description provided.

@pkozlowski-opensource
feat(core): mark signal-based query APIs as stable
cd929ec 
This commit marks the contentChild, contentChildren, viewChild
and viewChildren APIs (along with any associated APIs) as stable
and thus exits the dev preview
phase for those APIs.
@pkozlowski-opensource
docs: reword signal queries section
3259a72 
Reword the Results availability timing section
based on the feedback in angular#56866

Fixes angular#56866
@pkozlowski-opensource pkozlowski-opensource added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels Sep 23, 2024
@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: docs Related to the documentation area: core Issues related to the framework runtime labels Sep 23, 2024
@ngbot ngbot bot added this to the Backlog milestone Sep 23, 2024
@pkozlowski-opensource pkozlowski-opensource mentioned this pull request Sep 23, 2024
Closed
@pkozlowski-opensource
Copy link
Member Author

@devversion I'm "optimistically" marking the query APIs as stable - can hold off merging until we've migrated fonts, just to make sure that we didn't miss anything.

devversion
devversion approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on stabilization, but yeah, maybe wait until until tomorrow to sync up on fonts?

@pkozlowski-opensource pkozlowski-opensource added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 24, 2024
@pkozlowski-opensource
Copy link
Member Author

This PR was merged into the repository by commit 030ffb2.

The changes were merged into the following branches: main

pkozlowski-opensource added a commit that referenced this pull request Sep 24, 2024
@pkozlowski-opensource
docs: reword signal queries section (#57921)
030ffb2 
Reword the Results availability timing section
based on the feedback in #56866

Fixes #56866

PR Close #57921
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime area: docs Related to the documentation detected: feature PR contains a feature commit target: major This PR is targeted for the next major release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
3 participants
@pkozlowski-opensource @JeanMeche @devversion