fix(core): allow signal write error #57973
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that effects allow to write to signals (see angular@4e890cc), the SIGNAL_WRITE_FROM_ILLEGAL_CONTEXT error is only thrown in `computed` functions. This commit updates the error message to remove the mention of effects and of the deprecated `allowSignalWrites` option.
pkozlowski-opensource
approved these changes
Oct 3, 2024
|
This PR was merged into the repository by commit ee426c6. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Now that effects allow to write to signals (see 4e890cc), the SIGNAL_WRITE_FROM_ILLEGAL_CONTEXT error is only thrown in
computedfunctions.What is the new behavior?
This commit updates the error message to remove the mention of effects and of the deprecated
allowSignalWritesoption.Does this PR introduce a breaking change?
Other information