Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor(platform-browser): remove deprecated BrowserModule.withServerTransition method #58062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

alan-agius4
Copy link
Contributor

BREAKING CHANGE: The deprecated BrowserModule.withServerTransition method has been removed. Please use the APP_ID DI token to set the application id instead.

@pullapprove pullapprove bot requested a review from thePunderWoman October 3, 2024 11:07
@angular-robot angular-robot bot added the detected: breaking change PR contains a commit with a breaking change label Oct 3, 2024
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release detected: breaking change PR contains a commit with a breaking change state: blocked and removed detected: breaking change PR contains a commit with a breaking change labels Oct 3, 2024
@alan-agius4
Copy link
Contributor Author

alan-agius4 commented Oct 3, 2024

Looks like there are still a couple of usages in G3 which require some cleanup.

http://cl/681819294

Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@pullapprove pullapprove bot requested a review from alxhub October 3, 2024 17:32
Copy link
Member

@pkozlowski-opensource pkozlowski-opensource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: public-api
Reviewed-for: fw-core

@AndrewKushnir AndrewKushnir removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Oct 4, 2024
…erTransition` method

BREAKING CHANGE: The deprecated `BrowserModule.withServerTransition` method has been removed. Please use the `APP_ID` DI token to set the application id instead.
@alan-agius4 alan-agius4 force-pushed the remove-withServerTransition branch from 8a7a748 to fd9f53e Compare October 7, 2024 11:44
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Oct 7, 2024
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 5c61f46.

The changes were merged into the following branches: main

@alan-agius4 alan-agius4 deleted the remove-withServerTransition branch October 7, 2024 16:36
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker detected: breaking change PR contains a commit with a breaking change target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants