Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor(core): remove deprecated factories Property in KeyValueDiffers #58064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

refactor(core): remove deprecated factories Property in KeyValueDiffers #58064

wants to merge 1 commit into from

Conversation

alan-agius4
Copy link
Contributor

BREAKING CHANGE: The deprecated factories property in KeyValueDiffers has been removed.

@alan-agius4
refactor(core): remove deprecated factories Property in `KeyValueDi…
45d0f81 
…ffers`

BREAKING CHANGE: The deprecated `factories` property in `KeyValueDiffers` has been removed.
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels Oct 3, 2024
@pullapprove pullapprove bot requested a review from crisbeto October 3, 2024 11:19
@angular-robot angular-robot bot added detected: breaking change PR contains a commit with a breaking change area: core Issues related to the framework runtime labels Oct 3, 2024
@ngbot ngbot bot added this to the Backlog milestone Oct 3, 2024
pkozlowski-opensource
pkozlowski-opensource approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@pkozlowski-opensource pkozlowski-opensource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: public-api
Reviewed-for: fw-core

@pullapprove pullapprove bot requested a review from AndrewKushnir October 3, 2024 16:06
AndrewKushnir
AndrewKushnir approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@AndrewKushnir AndrewKushnir removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Oct 4, 2024
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Oct 4, 2024
@devversion
Copy link
Member

This PR was merged into the repository by commit c15ec36.

The changes were merged into the following branches: main

@devversion devversion closed this in c15ec36 Oct 4, 2024
@alan-agius4 alan-agius4 deleted the factories-key-valuer-diff branch October 4, 2024 15:43
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pkozlowski-opensource pkozlowski-opensource pkozlowski-opensource approved these changes

@crisbeto crisbeto crisbeto approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime detected: breaking change PR contains a commit with a breaking change target: major This PR is targeted for the next major release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
5 participants
@alan-agius4 @devversion @pkozlowski-opensource @crisbeto @AndrewKushnir