Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(language-service): support converting to signal queries in VSCode extension #58106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

devversion
Copy link
Member

See individual commits

…migrate`

This allows us to return extra properties along with `#migrate`
replacements. Useful for language service integration or other
integrations of Tsurge migrations in special runners.
@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: migrations Issues related to `ng update` migrations area: language-service Issues related to Angular's VS Code language service labels Oct 7, 2024
@ngbot ngbot bot added this to the Backlog milestone Oct 7, 2024
@devversion devversion requested a review from crisbeto October 7, 2024 12:30
@devversion devversion added action: review The PR is still awaiting reviews from at least one requested reviewer PullApprove: disable and removed PullApprove: disable labels Oct 7, 2024
@devversion devversion marked this pull request as ready for review October 7, 2024 12:31
…ing TCB information

Whenever information is requested from the template checker right now,
the shim is only ensured to be generated for the single file/component.
This is slow in migrations where we don't want to collect diagnostics,
but rather request information from the component state.

This commit supports `OptimizeFor` in `checker#getTemplate`.
Instead of inspecting all types of property accesses, we can use a
similar optimization we did for TS references— leveraging the list of
known field names to minimize type checker calls.
…e extension

This commit adds support for converting decorator queries to signal queries
via the VSCode extension.

Note that this is not fully finished as we still need to add better
messaging when certain fields could not be migrated.

In addition, it's worth noting that the migration is not as safe as the
input migration because commonly query lists are passed around— this
quickly can break the build— but is an acceptable trade-off for the work
saved. A migration cannot be 100% correct in general; there are always
edge-cases.
@devversion
Copy link
Member Author

Caretaker note: Please include https://critique.corp.google.com/cl/683183773 into your sync.

@devversion devversion added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Oct 7, 2024
@devversion devversion added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 8, 2024
@devversion
Copy link
Member Author

This PR was merged into the repository by commit bc83fc1.

The changes were merged into the following branches: main

@devversion devversion closed this in 754a857 Oct 8, 2024
devversion added a commit that referenced this pull request Oct 8, 2024
…ing TCB information (#58106)

Whenever information is requested from the template checker right now,
the shim is only ensured to be generated for the single file/component.
This is slow in migrations where we don't want to collect diagnostics,
but rather request information from the component state.

This commit supports `OptimizeFor` in `checker#getTemplate`.

PR Close #58106
devversion added a commit that referenced this pull request Oct 8, 2024
)

Instead of inspecting all types of property accesses, we can use a
similar optimization we did for TS references— leveraging the list of
known field names to minimize type checker calls.

PR Close #58106
devversion added a commit that referenced this pull request Oct 8, 2024
…e extension (#58106)

This commit adds support for converting decorator queries to signal queries
via the VSCode extension.

Note that this is not fully finished as we still need to add better
messaging when certain fields could not be migrated.

In addition, it's worth noting that the migration is not as safe as the
input migration because commonly query lists are passed around— this
quickly can break the build— but is an acceptable trade-off for the work
saved. A migration cannot be 100% correct in general; there are always
edge-cases.

PR Close #58106
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: language-service Issues related to Angular's VS Code language service area: migrations Issues related to `ng update` migrations detected: feature PR contains a feature commit merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note PullApprove: disable target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants