-
Notifications
You must be signed in to change notification settings - Fork 26.3k
feat(language-service): support converting to signal queries in VSCode extension #58106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…migrate` This allows us to return extra properties along with `#migrate` replacements. Useful for language service integration or other integrations of Tsurge migrations in special runners.
…ing TCB information Whenever information is requested from the template checker right now, the shim is only ensured to be generated for the single file/component. This is slow in migrations where we don't want to collect diagnostics, but rather request information from the component state. This commit supports `OptimizeFor` in `checker#getTemplate`.
Instead of inspecting all types of property accesses, we can use a similar optimization we did for TS references— leveraging the list of known field names to minimize type checker calls.
5d389be
to
7297bd6
Compare
…e extension This commit adds support for converting decorator queries to signal queries via the VSCode extension. Note that this is not fully finished as we still need to add better messaging when certain fields could not be migrated. In addition, it's worth noting that the migration is not as safe as the input migration because commonly query lists are passed around— this quickly can break the build— but is an acceptable trade-off for the work saved. A migration cannot be 100% correct in general; there are always edge-cases.
7297bd6
to
3c3cb0c
Compare
Caretaker note: Please include https://critique.corp.google.com/cl/683183773 into your sync. |
This PR was merged into the repository by commit bc83fc1. The changes were merged into the following branches: main |
…ing TCB information (#58106) Whenever information is requested from the template checker right now, the shim is only ensured to be generated for the single file/component. This is slow in migrations where we don't want to collect diagnostics, but rather request information from the component state. This commit supports `OptimizeFor` in `checker#getTemplate`. PR Close #58106
) Instead of inspecting all types of property accesses, we can use a similar optimization we did for TS references— leveraging the list of known field names to minimize type checker calls. PR Close #58106
…e extension (#58106) This commit adds support for converting decorator queries to signal queries via the VSCode extension. Note that this is not fully finished as we still need to add better messaging when certain fields could not be migrated. In addition, it's worth noting that the migration is not as safe as the input migration because commonly query lists are passed around— this quickly can break the build— but is an acceptable trade-off for the work saved. A migration cannot be 100% correct in general; there are always edge-cases. PR Close #58106
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
See individual commits