Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(compiler-cli): Adapt the compiler to use standalone by default. #58169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

feat(compiler-cli): Adapt the compiler to use standalone by default. #58169

wants to merge 9 commits into from

Conversation

JeanMeche
Copy link
Member

@JeanMeche JeanMeche commented Oct 11, 2024 •
edited
Loading

On top of #58160 & #58175

This PR flips the default for standalone from false to true for components, directives and pipes.
This PR also includes the necessary changes for the impacted tests as well as other targets that dependens on them (adev, benchmarks etc).

@angular-robot angular-robot bot added detected: breaking change PR contains a commit with a breaking change detected: feature PR contains a feature commit area: build & ci Related the build and CI infrastructure of the project area: core Issues related to the framework runtime area: docs-infra Angular.dev application and infrastructure labels Oct 11, 2024
@ngbot ngbot bot added this to the Backlog milestone Oct 11, 2024
@angular-robot angular-robot bot added area: devtools area: language-service Issues related to Angular's VS Code language service area: compiler Issues related to `ngc`, Angular's template compiler labels Oct 11, 2024
@JeanMeche JeanMeche added state: blocked target: major This PR is targeted for the next major release labels Oct 11, 2024
@angular-robot angular-robot bot added area: core Issues related to the framework runtime area: compiler Issues related to `ngc`, Angular's template compiler area: migrations Issues related to `ng update` migrations and removed area: compiler Issues related to `ngc`, Angular's template compiler area: core Issues related to the framework runtime labels Oct 11, 2024
@JeanMeche JeanMeche force-pushed the feat/standalone-standalone-compiler branch from 480c7f9 to 408084f Compare October 11, 2024 15:02
@angular-robot angular-robot bot added area: core Issues related to the framework runtime area: compiler Issues related to `ngc`, Angular's template compiler and removed area: compiler Issues related to `ngc`, Angular's template compiler area: core Issues related to the framework runtime labels Oct 11, 2024
@JeanMeche JeanMeche force-pushed the feat/standalone-standalone-compiler branch from 408084f to 5c327a2 Compare October 11, 2024 15:10
@angular-robot angular-robot bot removed the area: compiler Issues related to `ngc`, Angular's template compiler label Oct 11, 2024
@angular-robot angular-robot bot added area: core Issues related to the framework runtime area: compiler Issues related to `ngc`, Angular's template compiler and removed area: compiler Issues related to `ngc`, Angular's template compiler area: core Issues related to the framework runtime labels Oct 15, 2024
jelbourn
jelbourn approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: global-approvers

@jelbourn jelbourn added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Oct 15, 2024
@jelbourn
Copy link
Member

Caretaker note: presubmit failure looks like a flake to me; I ran a TGP for these changes yesterday and it was green

@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Oct 15, 2024
@devversion
Copy link
Member

This PR was merged into the repository by commit 9ab663e.

The changes were merged into the following branches: main

devversion pushed a commit that referenced this pull request Oct 15, 2024
@JeanMeche @devversion
refactor(compiler): dynamic default for the partial compiler. (#58169)
a34090b 
Use `semver` in the partial compiler to decide on a default value

Co-authored-by: Alex Rickabaugh <[email protected]>

PR Close #58169
devversion pushed a commit that referenced this pull request Oct 15, 2024
@JeanMeche @devversion
refactor(upgrade): update API golden. (#58169)
4157bf0 
`UpgradeComponent` is meant to be used as a subclass, it doesn't need to disable `standalone`.

PR Close #58169
devversion pushed a commit that referenced this pull request Oct 15, 2024
@JeanMeche @devversion
refactor(compiler-cli): Update Golden partials (#58169)
b631bb4 
After flipping the standalone default value, this is reflected in the partial output result.

PR Close #58169
devversion pushed a commit that referenced this pull request Oct 15, 2024
@JeanMeche @devversion
refactor(compiler-cli): Migrate manually ngtsc tests to standalone by…
7ed5665 
… default (#58169)

This commit is part of the migration to standalone by default.

PR Close #58169
devversion pushed a commit that referenced this pull request Oct 15, 2024
@JeanMeche @devversion
refactor(migrations): Port standalone migration to standalone by defa…
9ab663e 
…ult (#58169)

With this commit, the standalone migration will only migrate code with `standalone: false` to standalone by default (without the standalone attribute)

PR Close #58169
@JeanMeche JeanMeche deleted the feat/standalone-standalone-compiler branch October 15, 2024 16:51
This was referenced Oct 15, 2024
Merged
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir left review comments

@jelbourn jelbourn jelbourn approved these changes

@alxhub alxhub alxhub approved these changes

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler area: core Issues related to the framework runtime area: devtools area: docs-infra Angular.dev application and infrastructure area: language-service Issues related to Angular's VS Code language service area: migrations Issues related to `ng update` migrations area: upgrade Issues related to AngularJS → Angular upgrade APIs detected: feature PR contains a feature commit merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
5 participants
@JeanMeche @jelbourn @devversion @alxhub @AndrewKushnir