Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(core): Promote takeUntilDestroyed to stable. #58200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

JeanMeche
Copy link
Member

takeUntilDestroyed is now part of the public API.

`takeUntilDestroyed` is now part of the public API.
@JeanMeche JeanMeche requested a review from alxhub October 15, 2024 03:00
@ngbot ngbot bot removed this from the v19 Feature Freeze Candidates milestone Oct 15, 2024
@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: core Issues related to the framework runtime labels Oct 15, 2024
@ngbot ngbot bot modified the milestone: Backlog Oct 15, 2024
Copy link

@ChristianSchwarz ChristianSchwarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better wait until #58008 is merged

Copy link
Member

@pkozlowski-opensource pkozlowski-opensource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: public-api
Reviewed-for: fw-core

@pkozlowski-opensource pkozlowski-opensource removed the request for review from alxhub October 15, 2024 12:34
@pkozlowski-opensource pkozlowski-opensource added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Oct 15, 2024
@pkozlowski-opensource
Copy link
Member

caretaker note: docs only change, I don't think we need presubmit here

@devversion
Copy link
Member

This PR was merged into the repository by commit 97c44a1.

The changes were merged into the following branches: main

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime detected: feature PR contains a feature commit merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants