Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(core): promote outputFromObservable & outputToObservable to stable #58214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

JeanMeche
Copy link
Member

Alongside the promotion of output() to stable, we promote those 2 related interops.

…stable.

Alongside the promotion of `output()` to stable, we promote those 2 related interops.
@pullapprove pullapprove bot requested a review from thePunderWoman October 16, 2024 01:23
@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: core Issues related to the framework runtime labels Oct 16, 2024
@ngbot ngbot bot added this to the Backlog milestone Oct 16, 2024
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also adding @pkozlowski-opensource as reviewer though. We haven't had a chance to discuss these specific APIs in detail yet, but I'm not aware of any blockers.

Copy link
Member

@pkozlowski-opensource pkozlowski-opensource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Agree that i'm not aware of any blockers / complains so let's promote it to stable.

Reviewed-for: public-api
Reviewed-for: fw-core

@pkozlowski-opensource pkozlowski-opensource added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release labels Oct 16, 2024
@pkozlowski-opensource pkozlowski-opensource removed the request for review from thePunderWoman October 16, 2024 12:33
@devversion devversion added the action: presubmit The PR is in need of a google3 presubmit label Oct 16, 2024
@devversion
Copy link
Member

This PR was merged into the repository by commit 3f1e7ab.

The changes were merged into the following branches: main

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker action: presubmit The PR is in need of a google3 presubmit area: core Issues related to the framework runtime detected: feature PR contains a feature commit target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants