Migration outputs in templates #58282
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This build change makes it possible to share code between existing input / query migrations and output migrations.
25e66de to
b88773a
Compare
This commits makes sure that .next usages of outputs are migrated in templates and host bindings.
b88773a to
cda1534
Compare
devversion
approved these changes
Oct 21, 2024
packages/core/schematics/migrations/output-migration/output-migration.ts
Outdated
Show resolved
Hide resolved
packages/core/schematics/migrations/output-migration/output-migration.ts
Outdated
Show resolved
Hide resolved
packages/core/schematics/migrations/output-migration/output-migration.ts
Outdated
Show resolved
Hide resolved
|
caretaker note: merging this PR will require a patch from https://critique.corp.google.com/cl/688139268 (G3 BUILD files update). |
|
This PR was merged into the repository by commit 00e2001. The changes were merged into the following branches: main |
AndrewKushnir
pushed a commit
that referenced
this pull request
Oct 21, 2024
This commits makes sure that .next usages of outputs are migrated in templates and host bindings. PR Close #58282
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change tracks usage of outputs in templates / host bindings. For now it replaces
.nextusage with.emitbut we might need to add more processing if needed (ex..pipeusage - for now I'm assuming that this is not very common / not happening).