Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Output ng generate #58299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Output ng generate #58299

wants to merge 3 commits into from

Conversation

pkozlowski-opensource
Copy link
Member

No description provided.

@pkozlowski-opensource
feat(core): allow running output migration on a subset of paths
1673a9b 
This change introduces a new configuration parameter to the
output as function migration - it is now possible to restrict
a set of migrated paths.
@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: core Issues related to the framework runtime area: migrations Issues related to `ng update` migrations labels Oct 22, 2024
@ngbot ngbot bot added this to the Backlog milestone Oct 22, 2024
@pkozlowski-opensource pkozlowski-opensource added the target: minor This PR is targeted for the next minor release label Oct 22, 2024
@pkozlowski-opensource pkozlowski-opensource marked this pull request as ready for review October 22, 2024 11:57
@pkozlowski-opensource pkozlowski-opensource added the action: review The PR is still awaiting reviews from at least one requested reviewer label Oct 22, 2024
@pullapprove pullapprove bot requested a review from thePunderWoman October 22, 2024 11:57
@pkozlowski-opensource pkozlowski-opensource requested review from alan-agius4 and removed request for thePunderWoman October 22, 2024 11:57
@pkozlowski-opensource pkozlowski-opensource mentioned this pull request Oct 22, 2024
Closed
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Oct 22, 2024
devversion
devversion approved these changes Oct 22, 2024
View reviewed changes
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Oct 22, 2024
alan-agius4
alan-agius4 approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alan-agius4 alan-agius4 removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Oct 22, 2024
pkozlowski-opensource and others added 2 commits October 22, 2024 15:10
@pkozlowski-opensource
feat(migrations): expose output as function migration
b107ed6 
This commit exposes a new ng generate schematic that migrates
outputs from the decorator version to the output function.
@alan-agius4 @pkozlowski-opensource
build(migrations): skip source map generation
8de8c85 
Remove the usage of MagicString and the generation of intermediate sourcemaps,
as sourcemaps are never included in the schematic bundles. Peparing source maps
is a CPU / memory intensive and was causing OoO errors in rollup.
@angular-robot angular-robot bot added area: build & ci Related the build and CI infrastructure of the project area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Oct 22, 2024
@pkozlowski-opensource pkozlowski-opensource added the action: merge The PR is ready for merge by the caretaker label Oct 22, 2024
@pkozlowski-opensource pkozlowski-opensource removed this from the Backlog milestone Oct 22, 2024
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 3595445.

The changes were merged into the following branches: main

AndrewKushnir pushed a commit that referenced this pull request Oct 22, 2024
@pkozlowski-opensource @AndrewKushnir
feat(migrations): expose output as function migration (#58299)
2bfc64d 
This commit exposes a new ng generate schematic that migrates
outputs from the decorator version to the output function.

PR Close #58299
AndrewKushnir pushed a commit that referenced this pull request Oct 22, 2024
@alan-agius4 @AndrewKushnir
build(migrations): skip source map generation (#58299)
3595445 
Remove the usage of MagicString and the generation of intermediate sourcemaps,
as sourcemaps are never included in the schematic bundles. Peparing source maps
is a CPU / memory intensive and was causing OoO errors in rollup.

PR Close #58299
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@alan-agius4 alan-agius4 alan-agius4 approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project area: core Issues related to the framework runtime area: migrations Issues related to `ng update` migrations detected: feature PR contains a feature commit target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
v19 Feature Freeze Candidates
Development

Successfully merging this pull request may close these issues.
4 participants
@pkozlowski-opensource @AndrewKushnir @devversion @alan-agius4