Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(compiler-cli): disable standalone by default on older versions of Angular #58405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 29, 2024

Disables the standalone by default behavior in the compiler when running against and older version of Angular. This is necessary, because the language service may be using the latest version of the compiler against and older version of core in a particular workspace.

@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer area: compiler Issues related to `ngc`, Angular's template compiler target: rc This PR is targeted for the next release-candidate labels Oct 29, 2024
@ngbot ngbot bot added this to the Backlog milestone Oct 29, 2024
@angular-robot angular-robot bot removed the area: compiler Issues related to `ngc`, Angular's template compiler label Oct 29, 2024
@ngbot ngbot bot removed this from the Backlog milestone Oct 29, 2024
@crisbeto crisbeto force-pushed the language-service-standalone-flag branch from 7731219 to 3f67209 Compare October 29, 2024 10:08
@crisbeto crisbeto requested a review from alxhub October 29, 2024 10:25
@crisbeto crisbeto marked this pull request as ready for review October 29, 2024 10:25
… Angular

Disables the standalone by default behavior in the compiler when running against and older version of Angular. This is necessary, because the language service may be using the latest version of the compiler against and older version of core in a particular workspace.
@crisbeto crisbeto force-pushed the language-service-standalone-flag branch from 3f67209 to 3d887e8 Compare October 29, 2024 12:49
@crisbeto crisbeto changed the title fix(compiler-cli): add private opt-out for standalone by default fix(compiler-cli): disable standalone by default on older versions of Angular Oct 29, 2024
@crisbeto crisbeto removed the request for review from alxhub October 29, 2024 16:21
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 29, 2024
@crisbeto crisbeto added this to the v19 final milestone Oct 30, 2024
@ngbot ngbot bot removed this from the v19 final milestone Oct 30, 2024
@crisbeto crisbeto added this to the v19 final milestone Oct 30, 2024
@ngbot ngbot bot removed this from the v19 final milestone Oct 30, 2024
@alxhub
Copy link
Member

alxhub commented Oct 30, 2024

This PR was merged into the repository by commit 2f9af91.

The changes were merged into the following branches: main, 19.0.x

alxhub pushed a commit that referenced this pull request Oct 30, 2024
… Angular (#58405)

Disables the standalone by default behavior in the compiler when running against and older version of Angular. This is necessary, because the language service may be using the latest version of the compiler against and older version of core in a particular workspace.

PR Close #58405
@alxhub alxhub closed this in 2f9af91 Oct 30, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants