Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(migrations): properly migrate output aliases #58411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(migrations): properly migrate output aliases #58411

wants to merge 1 commit into from

Conversation

pkozlowski-opensource
Copy link
Member

Before this fix the output migration was incorrectly assuming that the @output decorator takes its params as an object. What happens in reality is that the @output decorator is taking alias as the only argument, without any object literal wrapper.

@pkozlowski-opensource
fix(migrations): properly migrate output aliases
e774ad9 
Before this fix the output migration was incorrectly assuming
that the @output decorator takes its params as an object.
What happens in reality is that the @output decorator is taking
alias as the only argument, without any object literal wrapper.
@pullapprove pullapprove bot requested a review from crisbeto October 29, 2024 15:00
@angular-robot angular-robot bot added the area: migrations Issues related to `ng update` migrations label Oct 29, 2024
@ngbot ngbot bot added this to the Backlog milestone Oct 29, 2024
@pkozlowski-opensource pkozlowski-opensource added action: review The PR is still awaiting reviews from at least one requested reviewer target: rc This PR is targeted for the next release-candidate labels Oct 29, 2024
@pkozlowski-opensource pkozlowski-opensource removed the request for review from crisbeto October 29, 2024 15:32
@pkozlowski-opensource pkozlowski-opensource added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 29, 2024
@alxhub
Copy link
Member

alxhub commented Oct 30, 2024

This PR was merged into the repository by commit 3161360.

The changes were merged into the following branches: main, 19.0.x

alxhub pushed a commit that referenced this pull request Oct 30, 2024
@pkozlowski-opensource @alxhub
fix(migrations): properly migrate output aliases (#58411)
616b411 
Before this fix the output migration was incorrectly assuming
that the @output decorator takes its params as an object.
What happens in reality is that the @output decorator is taking
alias as the only argument, without any object literal wrapper.

PR Close #58411
@alxhub alxhub closed this in 3161360 Oct 30, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: migrations Issues related to `ng update` migrations target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
v19 final
Development

Successfully merging this pull request may close these issues.
3 participants
@pkozlowski-opensource @alxhub @devversion