Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(core): prevent errors on contract cleanup #58614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(core): prevent errors on contract cleanup #58614

wants to merge 1 commit into from

Conversation

thePunderWoman
Copy link
Contributor

If contract cleanup is called more than once, the assertion that the container manager will be present results in exceptions.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix

Does this PR introduce a breaking change?

  • Yes
  • No

@thePunderWoman
fix(core): prevent errors on contract cleanup
a30917e 
If contract cleanup is called more than once, the assertion that the container manager will be present results in exceptions.
@thePunderWoman thePunderWoman added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: rc This PR is targeted for the next release-candidate labels Nov 12, 2024
@ngbot ngbot bot modified the milestone: Backlog Nov 12, 2024
@pullapprove pullapprove bot added the requires: TGP This PR requires a passing TGP before merging is allowed label Nov 12, 2024
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Nov 12, 2024
@ngbot ngbot bot modified the milestone: Backlog Nov 12, 2024
@thePunderWoman thePunderWoman requested review from AndrewKushnir and removed request for tbondwilkinson November 12, 2024 17:03
@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 12, 2024
@thePunderWoman
Copy link
Contributor Author

TESTED=Low Risk. No TGP needed.

thePunderWoman added a commit that referenced this pull request Nov 12, 2024
@thePunderWoman
fix(core): prevent errors on contract cleanup (#58614)
51933ef 
If contract cleanup is called more than once, the assertion that the container manager will be present results in exceptions.

PR Close #58614
@thePunderWoman
Copy link
Contributor Author

This PR was merged into the repository by commit f2bda8e.

The changes were merged into the following branches: main, 19.0.x

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 13, 2024
@thePunderWoman thePunderWoman deleted the safe-cleanup branch March 6, 2025 20:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iteriani iteriani iteriani approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime requires: TGP This PR requires a passing TGP before merging is allowed target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
3 participants
@thePunderWoman @iteriani @AndrewKushnir