-
Notifications
You must be signed in to change notification settings - Fork 26.3k
Css fixes main #58681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
pkozlowski-opensource
wants to merge
4
commits into
angular:main
from
pkozlowski-opensource:css_fixes_main
Closed
Css fixes main #58681
pkozlowski-opensource
wants to merge
4
commits into
angular:main
from
pkozlowski-opensource:css_fixes_main
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix several use-cases where `:host` was used in or around pseudo-selectors - `:host` followed by a comma inside pseudo-selectors - `:host` outside of pseudo-selectors when another `:host` is present within see tests for examples
fix transformation logic for `:where` and `:is` pseudo-selectors when these selectors were used in a chain. results were often broken, the last letter of the selector was incorrectly trimmed. see tests for examples Fixes angular#58226
fix results which had to parse several `-shadowcsshost-no-combinator` occurrences in a single selector
multiline selectors where not correctly recognized by the regexp, fix it to fetch newlines as well Fixes angular#58399
alxhub
approved these changes
Nov 15, 2024
crisbeto
approved these changes
Nov 15, 2024
6 tasks
This PR was merged into the repository by commit 549a00d. The changes were merged into the following branches: main, 19.0.x |
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Nov 15, 2024
fix several use-cases where `:host` was used in or around pseudo-selectors - `:host` followed by a comma inside pseudo-selectors - `:host` outside of pseudo-selectors when another `:host` is present within see tests for examples PR Close #58681
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Nov 15, 2024
fix results which had to parse several `-shadowcsshost-no-combinator` occurrences in a single selector PR Close #58681
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Nov 15, 2024
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Nov 15, 2024
fix results which had to parse several `-shadowcsshost-no-combinator` occurrences in a single selector PR Close #58681
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Nov 15, 2024
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action: merge
The PR is ready for merge by the caretaker
area: compiler
Issues related to `ngc`, Angular's template compiler
target: rc
This PR is targeted for the next release-candidate
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the version of PR #58557 that targets the main branch