Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Css fixes main #58681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

pkozlowski-opensource
Copy link
Member

@pkozlowski-opensource pkozlowski-opensource commented Nov 15, 2024

This is the version of PR #58557 that targets the main branch

fix several use-cases where `:host` was used in or around pseudo-selectors
- `:host` followed by a comma inside pseudo-selectors
- `:host` outside of pseudo-selectors when another `:host` is present within
see tests for examples
fix transformation logic for `:where` and `:is` pseudo-selectors
when these selectors were used in a chain. results were often broken,
the last letter of the selector was incorrectly trimmed.
see tests for examples

Fixes angular#58226
fix results which had to parse several `-shadowcsshost-no-combinator` occurrences in a single selector
multiline selectors where not correctly recognized by the regexp, fix it to fetch newlines as well

Fixes angular#58399
@pullapprove pullapprove bot requested a review from crisbeto November 15, 2024 09:52
@pkozlowski-opensource pkozlowski-opensource added the target: rc This PR is targeted for the next release-candidate label Nov 15, 2024
@angular-robot angular-robot bot added the area: compiler Issues related to `ngc`, Angular's template compiler label Nov 15, 2024
@ngbot ngbot bot added this to the Backlog milestone Nov 15, 2024
@pkozlowski-opensource pkozlowski-opensource added the action: merge The PR is ready for merge by the caretaker label Nov 15, 2024
@pkozlowski-opensource
Copy link
Member Author

This PR was merged into the repository by commit 549a00d.

The changes were merged into the following branches: main, 19.0.x

pkozlowski-opensource pushed a commit that referenced this pull request Nov 15, 2024
fix several use-cases where `:host` was used in or around pseudo-selectors
- `:host` followed by a comma inside pseudo-selectors
- `:host` outside of pseudo-selectors when another `:host` is present within
see tests for examples

PR Close #58681
pkozlowski-opensource pushed a commit that referenced this pull request Nov 15, 2024
fix transformation logic for `:where` and `:is` pseudo-selectors
when these selectors were used in a chain. results were often broken,
the last letter of the selector was incorrectly trimmed.
see tests for examples

Fixes #58226

PR Close #58681
pkozlowski-opensource pushed a commit that referenced this pull request Nov 15, 2024
fix results which had to parse several `-shadowcsshost-no-combinator` occurrences in a single selector

PR Close #58681
pkozlowski-opensource pushed a commit that referenced this pull request Nov 15, 2024
multiline selectors where not correctly recognized by the regexp, fix it to fetch newlines as well

Fixes #58399

PR Close #58681
pkozlowski-opensource pushed a commit that referenced this pull request Nov 15, 2024
fix transformation logic for `:where` and `:is` pseudo-selectors
when these selectors were used in a chain. results were often broken,
the last letter of the selector was incorrectly trimmed.
see tests for examples

Fixes #58226

PR Close #58681
pkozlowski-opensource pushed a commit that referenced this pull request Nov 15, 2024
fix results which had to parse several `-shadowcsshost-no-combinator` occurrences in a single selector

PR Close #58681
pkozlowski-opensource pushed a commit that referenced this pull request Nov 15, 2024
multiline selectors where not correctly recognized by the regexp, fix it to fetch newlines as well

Fixes #58399

PR Close #58681
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants