Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor(forms): work around another TypeScript 5.7 issue #58782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

refactor(forms): work around another TypeScript 5.7 issue #58782

wants to merge 1 commit into from

Conversation

crisbeto
Copy link
Member

Reworks the changes from #58731, because they didn't cover all use cases.

@crisbeto
refactor(forms): work around another TypeScript 5.7 issue
d5183e7 
Reworks the changes from angular#58731, because they didn't cover all use cases.
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Nov 20, 2024
@pullapprove pullapprove bot requested a review from alxhub November 20, 2024 18:52
@ngbot ngbot bot added this to the Backlog milestone Nov 20, 2024
@crisbeto crisbeto requested review from thePunderWoman and AndrewKushnir and removed request for alxhub November 20, 2024 20:14
thePunderWoman
thePunderWoman approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

reviewed-for: public-api

AndrewKushnir
AndrewKushnir approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@AndrewKushnir AndrewKushnir removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Nov 20, 2024
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Nov 20, 2024
thePunderWoman pushed a commit that referenced this pull request Nov 21, 2024
@crisbeto @thePunderWoman
refactor(forms): work around another TypeScript 5.7 issue (#58782)
6b057bc 
Reworks the changes from #58731, because they didn't cover all use cases.

PR Close #58782
@thePunderWoman
Copy link
Contributor

This PR was merged into the repository by commit cebf255.

The changes were merged into the following branches: main, 19.0.x

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thePunderWoman thePunderWoman thePunderWoman approved these changes

@alxhub alxhub alxhub approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: forms target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @thePunderWoman @alxhub @AndrewKushnir