feat(platform-browser): add Hammer provider functions #59480
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
HammerJS hasn't been updated in like 8 years or something. OOC is it really necessary to be part of Angular core? Sorry for the slightly off-topic question but just curious |
Prior to this commit, there were no functions that allowed providing HammerJS in a "new" way through environment providers; it required using `importProvidersFrom(HammerModule)` when bootstrapping the application. In this commit, we add two new functions that return environment providers and can be called directly in the providers when bootstrapping the application.
1f916a0 to
8e5b7e0
Compare
|
We'll actually go in the opposite direction an deprecating the integration of HammerJS in v20. See #60257 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, there were no functions that allowed providing HammerJS in a "new" way through environment providers; it required using
importProvidersFrom(HammerModule)when bootstrapping the application. In this commit, we add two new functions that return environment providers and can be called directly in the providers when bootstrapping the application.