Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Runtime refactor component ref directives #59633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Runtime refactor component ref directives #59633

wants to merge 2 commits into from

Conversation

pkozlowski-opensource
Copy link
Member

@pkozlowski-opensource pkozlowski-opensource commented Jan 20, 2025 •
edited
Loading

Note: only second commit to be reviewed (the first one is part of the #59601)

@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Jan 20, 2025
@ngbot ngbot bot added this to the Backlog milestone Jan 20, 2025
@pkozlowski-opensource pkozlowski-opensource force-pushed the runtime_refactor_component_ref_directives branch from 7131484 to 0c3f888 Compare January 21, 2025 09:52
@pkozlowski-opensource pkozlowski-opensource mentioned this pull request Jan 21, 2025
Closed
14 tasks
@pkozlowski-opensource pkozlowski-opensource marked this pull request as ready for review January 21, 2025 10:17
@pkozlowski-opensource pkozlowski-opensource added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jan 21, 2025
@AndrewKushnir AndrewKushnir added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Jan 21, 2025
@AndrewKushnir
Copy link
Contributor

@pkozlowski-opensource could you please rebase this PR and resolve merge conflicts when you get a chance? Thank you.

@pkozlowski-opensource
refactor(core): reuse directive instantiate logic
71f6c59 
This refactor reuses the existing directive instantiation
logic for a given component.
@pkozlowski-opensource pkozlowski-opensource force-pushed the runtime_refactor_component_ref_directives branch from 0c3f888 to 71f6c59 Compare January 21, 2025 20:28
@pkozlowski-opensource
Copy link
Member Author

@AndrewKushnir it is rebased now (I just had to drop the commit that was merged already in another PR)

@pkozlowski-opensource pkozlowski-opensource added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jan 21, 2025
AndrewKushnir
AndrewKushnir approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, left a couple minor comments, but they are not blocking, so I'll proceed with merging this PR.

@AndrewKushnir
Copy link
Contributor

Presubmit.

@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit c089d21.

The changes were merged into the following branches: main

pkozlowski-opensource added a commit to pkozlowski-opensource/angular that referenced this pull request Jan 22, 2025
@pkozlowski-opensource
Revert "refactor(core): reuse directive instantiate logic (angular#59633
c69202e 
)"

This reverts commit c089d21.
@pkozlowski-opensource
Copy link
Member Author

Re-opening as it is being reverted in #59659

pkozlowski-opensource added a commit that referenced this pull request Jan 22, 2025
@pkozlowski-opensource
Revert "refactor(core): reuse directive instantiate logic (#59633)" (#…
6c96d79 
…59659)

This reverts commit c089d21.

PR Close #59659
@pkozlowski-opensource pkozlowski-opensource removed the action: merge The PR is ready for merge by the caretaker label Jan 22, 2025
@pkozlowski-opensource pkozlowski-opensource added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jan 22, 2025
@pkozlowski-opensource pkozlowski-opensource force-pushed the runtime_refactor_component_ref_directives branch from e5777bd to 905b4bf Compare January 22, 2025 14:35
@pkozlowski-opensource
Copy link
Member Author

Update:

  • I've run a TGP and verified that the target that trigger the revert was the only one impacted
  • I've got a fix (in a fixup commit) and verified that it makes the tests in the problematic target to pass

@pkozlowski-opensource pkozlowski-opensource added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jan 22, 2025
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 3f6d9ff.

The changes were merged into the following branches: main

pkozlowski-opensource added a commit to pkozlowski-opensource/angular that referenced this pull request Jan 24, 2025
@pkozlowski-opensource
refactor(core): reuse directive instantiate logic (angular#59633)
935b8bc 
This refactor reuses the existing directive instantiation
logic for a given component.

This is 19.1.x version of the PR angular#59633
@pkozlowski-opensource pkozlowski-opensource mentioned this pull request Jan 24, 2025
Closed
pkozlowski-opensource added a commit that referenced this pull request Jan 24, 2025
@pkozlowski-opensource
refactor(core): reuse directive instantiate logic (#59633) (#59695)
9ea6337 
This refactor reuses the existing directive instantiation
logic for a given component.

This is 19.1.x version of the PR #59633

PR Close #59695
PrajaktaB27 pushed a commit to PrajaktaB27/angular that referenced this pull request Feb 7, 2025
@pkozlowski-opensource @PrajaktaB27
refactor(core): reuse directive instantiate logic (angular#59633)
a172a3f 
This refactor reuses the existing directive instantiation
logic for a given component.

PR Close angular#59633
PrajaktaB27 pushed a commit to PrajaktaB27/angular that referenced this pull request Feb 7, 2025
@pkozlowski-opensource @PrajaktaB27
Revert "refactor(core): reuse directive instantiate logic (angular#59633
d9fd59b 
)" (angular#59659)

This reverts commit c089d21.

PR Close angular#59659
PrajaktaB27 pushed a commit to PrajaktaB27/angular that referenced this pull request Feb 7, 2025
@pkozlowski-opensource @PrajaktaB27
refactor(core): reuse directive instantiate logic (angular#59633)
f52c35d 
This refactor reuses the existing directive instantiation
logic for a given component.

PR Close angular#59633
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
3 participants
@pkozlowski-opensource @AndrewKushnir @crisbeto