Thanks to visit codestin.com
Credit goes to github.com

Skip to content

test(zone.js): reduce flakiness of a timer-related test #59653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

AndrewKushnir
Copy link
Contributor

This commit updates a flaky test to increase the amount of work (more for loop iterations) to minimize the chance of getting the same timestamp after that work.

Does this PR introduce a breaking change?

  • Yes
  • No

This commit updates a flaky test to increase the amount of work (more `for` loop iterations) to minimize the chance of getting the same timestamp after that work.
@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer area: zones Issues related to zone.js target: patch This PR is targeted for the next patch release labels Jan 21, 2025
@ngbot ngbot bot modified the milestone: Backlog Jan 21, 2025
@pullapprove pullapprove bot requested a review from JiaLiPassion January 21, 2025 20:36
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker PullApprove: disable and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 21, 2025
@AndrewKushnir AndrewKushnir removed the request for review from JiaLiPassion January 21, 2025 21:19
@AndrewKushnir
Copy link
Contributor Author

This PR was merged into the repository by commit 4f46b02.

The changes were merged into the following branches: main, 19.1.x

AndrewKushnir added a commit that referenced this pull request Jan 21, 2025
This commit updates a flaky test to increase the amount of work (more `for` loop iterations) to minimize the chance of getting the same timestamp after that work.

PR Close #59653
PrajaktaB27 pushed a commit to PrajaktaB27/angular that referenced this pull request Feb 7, 2025
This commit updates a flaky test to increase the amount of work (more `for` loop iterations) to minimize the chance of getting the same timestamp after that work.

PR Close angular#59653
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: zones Issues related to zone.js PullApprove: disable target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants