Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Revert "refactor(core): reuse directive instantiate logic (#59633)" #59659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

pkozlowski-opensource
Copy link
Member

This reverts commit c089d21 as it breaks some of the existing tests in G3, will need more investigation before re-submitting.

@pkozlowski-opensource pkozlowski-opensource added the target: minor This PR is targeted for the next minor release label Jan 22, 2025
@pkozlowski-opensource pkozlowski-opensource marked this pull request as ready for review January 22, 2025 10:47
@pkozlowski-opensource pkozlowski-opensource added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Jan 22, 2025
@pkozlowski-opensource
Copy link
Member Author

caretaker note: this was already rolled back in G3, presubmit is empty

@pkozlowski-opensource
Copy link
Member Author

This PR was merged into the repository by commit 6c96d79.

The changes were merged into the following branches: main

PrajaktaB27 pushed a commit to PrajaktaB27/angular that referenced this pull request Feb 7, 2025
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants