fix(core): release hasPendingTasks observers
#59723
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ca940de to
e1bd64b
Compare
e1bd64b to
733de79
Compare
733de79 to
d88e914
Compare
d88e914 to
e765e0a
Compare
atscott
approved these changes
Mar 5, 2025
|
From the tests' point of view, it looks like very breaking. |
|
Yeah, unfortunately this is exceptionally breaking. |
|
This unfortunately is not landable due to the breaking nature of this change. Sorry, @arturovt. |
JeanMeche
reviewed
Mar 5, 2025
e765e0a to
dda22fe
Compare
dda22fe to
50467bb
Compare
atscott
reviewed
Mar 5, 2025
25f9b55 to
590f396
Compare
atscott
reviewed
Mar 6, 2025
packages/core/src/pending_tasks.ts
Outdated
| * In case the service is about to be destroyed, return a self-completing observable. | ||
| * Otherwise, return the observable that emits the current state of pending tasks. | ||
| */ | ||
| safeHasPendingTasks(): Observable<boolean> { |
There was a problem hiding this comment.
Let's instead make pendingTasks private and expose hasPendingTasks as the value and hasPendingTasksObservable as the observable version. There's no need to have a public "safeHasPendingTasks" along with an unsafe one that might bite your hand off.
8c3d1d2 to
df3c4ee
Compare
df3c4ee to
eb17e98
Compare
atscott
approved these changes
Mar 12, 2025
|
@arturovt Looks like this still has real failing tests. Can you address them? |
In this commit, we unsubscribe the `hasPendingTasks` subject to remove all active observers and enable granular garbage collection, as users may forget to unsubscribe manually when subscribing to `isStable`.
eb17e98 to
1bc7d7e
Compare
|
@thePunderWoman fixed unit tests. |
thePunderWoman
approved these changes
Apr 2, 2025
AndrewKushnir
approved these changes
Apr 2, 2025
|
This PR was merged into the repository by commit 1c7b356. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we unsubscribe the
hasPendingTaskssubject to remove all active observers and enable granular garbage collection, as users may forget to unsubscribe manually when subscribing toisStable.