refactor(compiler): remove empty string suffix from interpolati… #60066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a7c58e1 to
536b79a
Compare
c7a385e to
29cdcb6
Compare
crisbeto
reviewed
Feb 27, 2025
| if (interpolationParts.length > 0) { | ||
| // This handles potential undefined last suffix in the interpolationParts array. | ||
| if (interpolationParts[interpolationParts.length - 1] === undefined) { | ||
| interpolationParts.pop(); |
There was a problem hiding this comment.
Why do we need to mutate the array instead of skipping the last value when reading it instead?
There was a problem hiding this comment.
The next line is a interpolationParts.join()
There was a problem hiding this comment.
Couldn't we handle this at the call site by doing something like suffix || ''?
There was a problem hiding this comment.
If you prefer that we can go that road. It's 16 callsites but they are guarded by ngDevMode.
29cdcb6 to
5615563
Compare
5615563 to
1058c78
Compare
JeanMeche
commented
Feb 27, 2025
1058c78 to
9c99e9a
Compare
devversion
approved these changes
Mar 4, 2025
pkozlowski-opensource
approved these changes
Mar 5, 2025
|
LGTM but it needs rebase, hence cleanup |
9c99e9a to
ff78dd7
Compare
ff78dd7 to
223fb69
Compare
pkozlowski-opensource
approved these changes
Mar 5, 2025
pkozlowski-opensource
approved these changes
Mar 5, 2025
…on instructions With this change, interpolations that don't have a suffix will miss the last argument which was previously an empty string.
223fb69 to
c8f871c
Compare
josephperrott
approved these changes
Mar 10, 2025
|
This PR was merged into the repository by commit c73520b. The changes were merged into the following branches: main |
|
Caretaker note: presubmit is "green". |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…on instructions
With this change, interpolations that don't have a suffix will miss the last argument which was previously an empty string.