fix(core): Ensure ComponentFixture does not duplicate error reporting… #60104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from FakeAsync When using `fakeAsync`, if errors happen inside the Angular zone, they are also handled by the fakeAsync machinery. Rethrowing errors from the `NgZone.onError` subscription is not appropriate in this case because it results in the error being thrown twice. https://github.com/angular/angular/blob/db2f2d99c82aae52d8a0ae46616c6411d070b35e/packages/zone.js/lib/zone-spec/fake-async-test.ts#L783-L784 https://github.com/angular/angular/blob/db2f2d99c82aae52d8a0ae46616c6411d070b35e/packages/zone.js/lib/zone-spec/fake-async-test.ts#L473-L478
95251c3 to
7c3550c
Compare
AndrewKushnir
approved these changes
Feb 25, 2025
|
caretaker note: current approvals are sufficient for merge and there is a green TGP. |
|
This PR was merged into the repository by commit 962b59b. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… from FakeAsync
When using
fakeAsync, if errors happen inside the Angular zone, they are also handled by the fakeAsync machinery. Rethrowing errors from theNgZone.onErrorsubscription is not appropriate in this case because it results in the error being thrown twice.angular/packages/zone.js/lib/zone-spec/fake-async-test.ts
Lines 783 to 784 in db2f2d9
angular/packages/zone.js/lib/zone-spec/fake-async-test.ts
Lines 473 to 478 in db2f2d9