fix(core): defer block render failures should report to application e… #60149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewKushnir
approved these changes
Feb 27, 2025
0284276 to
3ee2d66
Compare
|
@atscott looks like there's a failing test |
…rror handler This commit updates error reporting of defer blocks to go to the application root error handler rather than the `ErrorHandler` token that may be provided by users. This ensures Angular has control over what happens when these errors are reported.
3ee2d66 to
5043217
Compare
|
@atscott can you start the presubmit for this? |
|
merge assistance: rerun green after the unrelated failures from this morning |
|
This PR was merged into the repository by commit fd12220. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rror handler
This commit updates error reporting of defer blocks to go to the application root error handler rather than the
ErrorHandlertoken that may be provided by users. This ensures Angular has control over what happens when these errors are reported.