Moving to target major. Unsurprisingly this causes tests to fail that are mocking the router. This will not be considered a breaking change but still might as well move it to major to avoid breaking tests in patch. That said though, TGP will determine whether this is even able to land as-is. Potentially, this will need to have ?.catch to avoid when stubs are returning undefined from the navigation.

Adding blocked, as this change will require further discussion. Developers using ZoneJS indirectly rely on the rejection to report to ErrorHandler. By adding the catch, errors will no longer be reported by default which is undesirable. These catch blocks could report directly to the error handler but would mean duplicate reports if we also make a change to the navigation pipeline to also directly report to error handler in order to ensure it's still done when resolveNavigationPromiseOnError is set to true.

caretaker note: This change now has a green TGP after ~5 fixes to tests in g3. A few were spying on navigateByUrl and not returning a promise. Two others were somehow getting the promise rejection swallowed by ZoneJS. I would not consider either of these to be noteworthy as a breaking change

This PR was merged into the repository by commit 219f41d.

The changes were merged into the following branches: main

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}