Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(core): emit template function for template related profiler hooks #60174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

feat(core): emit template function for template related profiler hooks #60174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 32 additions & 38 deletions devtools/projects/ng-devtools-backend/src/lib/hooks/profiler/native.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,7 @@ import {IdentityTracker, NodeArray} from '../identity-tracker';

import {getLifeCycleName, Hooks, Profiler} from './shared';

type ProfilerCallback = (
event: ɵProfilerEvent,
instanceOrLView: {} | null,
hookOrListener: any,
) => void;
type ProfilerCallback = (event: ɵProfilerEvent, instanceOrLView: {} | null, eventFn: any) => void;

/** Implementation of Profiler that utilizes framework APIs fire profiler hooks. */
export class NgProfiler extends Profiler {
Expand All @@ -29,22 +25,20 @@ export class NgProfiler extends Profiler {

constructor(config: Partial<Hooks> = {}) {
super(config);
this._setProfilerCallback(
(event: ɵProfilerEvent, instanceOrLView: {} | null, hookOrListener: any) => {
if (this[event] === undefined) {
return;
}

this[event](instanceOrLView, hookOrListener);
},
);
this._setProfilerCallback((event: ɵProfilerEvent, instanceOrLView: {} | null, eventFn: any) => {
if (this[event] === undefined) {
return;
}

this[event](instanceOrLView, eventFn);
});
this._initialize();
}

private _initialize(): void {
ngDebugClient().ɵsetProfiler(
(event: ɵProfilerEvent, instanceOrLView: {} | null = null, hookOrListener: any) =>
this._callbacks.forEach((cb) => cb(event, instanceOrLView, hookOrListener)),
(event: ɵProfilerEvent, instanceOrLView: {} | null = null, eventFn: any) =>
this._callbacks.forEach((cb) => cb(event, instanceOrLView, eventFn)),
);
}

Expand Down Expand Up @@ -74,107 +68,107 @@ export class NgProfiler extends Profiler {
});
}

[ɵProfilerEvent.BootstrapApplicationStart](_directive: any, _hookOrListener: any): void {
[ɵProfilerEvent.BootstrapApplicationStart](_directive: any, _eventFn: any): void {
// todo: implement
return;
}

[ɵProfilerEvent.BootstrapApplicationEnd](_directive: any, _hookOrListener: any): void {
[ɵProfilerEvent.BootstrapApplicationEnd](_directive: any, _eventFn: any): void {
// todo: implement
return;
}

[ɵProfilerEvent.BootstrapComponentStart](_directive: any, _hookOrListener: any): void {
[ɵProfilerEvent.BootstrapComponentStart](_directive: any, _eventFn: any): void {
// todo: implement
return;
}

[ɵProfilerEvent.BootstrapComponentEnd](_directive: any, _hookOrListener: any): void {
[ɵProfilerEvent.BootstrapComponentEnd](_directive: any, _eventFn: any): void {
// todo: implement
return;
}

[ɵProfilerEvent.ChangeDetectionStart](_directive: any, _hookOrListener: any): void {
[ɵProfilerEvent.ChangeDetectionStart](_directive: any, _eventFn: any): void {
// todo: implement
return;
}

[ɵProfilerEvent.ChangeDetectionEnd](_directive: any, _hookOrListener: any): void {
[ɵProfilerEvent.ChangeDetectionEnd](_directive: any, _eventFn: any): void {
// todo: implement
return;
}

[ɵProfilerEvent.ChangeDetectionSyncStart](_directive: any, _hookOrListener: any): void {
[ɵProfilerEvent.ChangeDetectionSyncStart](_directive: any, _eventFn: any): void {
// todo: implement
return;
}

[ɵProfilerEvent.ChangeDetectionSyncEnd](_directive: any, _hookOrListener: any): void {
[ɵProfilerEvent.ChangeDetectionSyncEnd](_directive: any, _eventFn: any): void {
// todo: implement
return;
}

[ɵProfilerEvent.AfterRenderHooksStart](_directive: any, _hookOrListener: any): void {
[ɵProfilerEvent.AfterRenderHooksStart](_directive: any, _eventFn: any): void {
// todo: implement
return;
}

[ɵProfilerEvent.AfterRenderHooksEnd](_directive: any, _hookOrListener: any): void {
[ɵProfilerEvent.AfterRenderHooksEnd](_directive: any, _eventFn: any): void {
// todo: implement
return;
}

[ɵProfilerEvent.ComponentStart](_directive: any, _hookOrListener: any): void {
[ɵProfilerEvent.ComponentStart](_directive: any, _eventFn: any): void {
// todo: implement
return;
}

[ɵProfilerEvent.ComponentEnd](_directive: any, _hookOrListener: any): void {
[ɵProfilerEvent.ComponentEnd](_directive: any, _eventFn: any): void {
// todo: implement
return;
}

[ɵProfilerEvent.DeferBlockStateStart](_directive: any, _hookOrListener: any): void {
[ɵProfilerEvent.DeferBlockStateStart](_directive: any, _eventFn: any): void {
// todo: implement
return;
}

[ɵProfilerEvent.DeferBlockStateEnd](_directive: any, _hookOrListener: any): void {
[ɵProfilerEvent.DeferBlockStateEnd](_directive: any, _eventFn: any): void {
// todo: implement
return;
}

[ɵProfilerEvent.DynamicComponentStart](_directive: any, _hookOrListener: any): void {
[ɵProfilerEvent.DynamicComponentStart](_directive: any, _eventFn: any): void {
// todo: implement
return;
}

[ɵProfilerEvent.DynamicComponentEnd](_directive: any, _hookOrListener: any): void {
[ɵProfilerEvent.DynamicComponentEnd](_directive: any, _eventFn: any): void {
// todo: implement
return;
}

[ɵProfilerEvent.HostBindingsUpdateStart](_directive: any, _hookOrListener: any): void {
[ɵProfilerEvent.HostBindingsUpdateStart](_directive: any, _eventFn: any): void {
// todo: implement
return;
}

[ɵProfilerEvent.HostBindingsUpdateEnd](_directive: any, _hookOrListener: any): void {
[ɵProfilerEvent.HostBindingsUpdateEnd](_directive: any, _eventFn: any): void {
// todo: implement
return;
}

[ɵProfilerEvent.TemplateCreateStart](_directive: any, _hookOrListener: any): void {
[ɵProfilerEvent.TemplateCreateStart](_directive: any, _eventFn: any): void {
// todo: implement
return;
}

[ɵProfilerEvent.TemplateCreateEnd](_directive: any, _hookOrListener: any): void {
[ɵProfilerEvent.TemplateCreateEnd](_directive: any, _eventFn: any): void {
// todo: implement
return;
}

[ɵProfilerEvent.TemplateUpdateStart](context: any, _hookOrListener: any): void {
[ɵProfilerEvent.TemplateUpdateStart](context: any, _eventFn: any): void {
if (!this._inChangeDetection) {
this._inChangeDetection = true;
runOutsideAngular(() => {
Expand Down Expand Up @@ -208,7 +202,7 @@ export class NgProfiler extends Profiler {
);
}

[ɵProfilerEvent.TemplateUpdateEnd](context: any, _hookOrListener: any): void {
[ɵProfilerEvent.TemplateUpdateEnd](context: any, _eventFn: any): void {
const position = this._tracker.getDirectivePosition(context);
const id = this._tracker.getDirectiveId(context);

Expand Down
4 changes: 2 additions & 2 deletions packages/core/src/render3/instructions/shared.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,15 +96,15 @@ export function executeTemplate<T>(
const preHookType = isUpdatePhase
? ProfilerEvent.TemplateUpdateStart
: ProfilerEvent.TemplateCreateStart;
profiler(preHookType, context as unknown as {});
profiler(preHookType, context as unknown as {}, templateFn);
templateFn(rf, context);
} finally {
setSelectedIndex(prevSelectedIndex);

const postHookType = isUpdatePhase
? ProfilerEvent.TemplateUpdateEnd
: ProfilerEvent.TemplateCreateEnd;
profiler(postHookType, context as unknown as {});
profiler(postHookType, context as unknown as {}, templateFn);
}
}

Expand Down
9 changes: 5 additions & 4 deletions packages/core/src/render3/profiler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,13 @@ export const setProfiler = (profiler: Profiler | null) => {
*
* @param event ProfilerEvent corresponding to the execution context
* @param instance component instance
* @param hookOrListener lifecycle hook function or output listener. The value depends on the
* execution context
* @param eventFn function associated with event.
* For example a template function, lifecycle hook, or output listener.
* The value depends on the execution context
* @returns
*/
export const profiler: Profiler = function (event, instance = null, hookOrListener) {
export const profiler: Profiler = function (event, instance = null, eventFn) {
if (profilerCallback != null /* both `null` and `undefined` */) {
profilerCallback(event, instance, hookOrListener);
profilerCallback(event, instance, eventFn);
}
};
2 changes: 1 addition & 1 deletion packages/core/src/render3/profiler_types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,5 +160,5 @@ export const enum ProfilerEvent {
* Profiler function which the runtime will invoke before and after user code.
*/
export interface Profiler {
(event: ProfilerEvent, instance?: {} | null, hookOrListener?: (e?: any) => any): void;
(event: ProfilerEvent, instance?: {} | null, eventFn?: Function): void;
}
6 changes: 1 addition & 5 deletions packages/core/test/acceptance/profiler_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,11 +443,7 @@ describe('profiler', () => {
return true;
}

profile = (
event: ProfilerEvent,
instance?: {} | null,
hookOrListener?: (e?: any) => any,
): void => {
profile = (event: ProfilerEvent, instance?: {} | null, eventFn?: Function): void => {
this.events.push(event);
};
}
Expand Down