refactor(core): getting resource value throws an error instead of returning undefined #60271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Humberd
commented
Mar 7, 2025
Humberd
commented
Mar 7, 2025
Humberd
commented
Mar 7, 2025
JeanMeche
reviewed
Mar 7, 2025
ada5ed0 to
2594a2c
Compare
alxhub
requested changes
Mar 20, 2025
946fdad to
e652c69
Compare
|
We would like to merge it after #60272 since both of these touch error handling. |
alxhub
reviewed
Mar 21, 2025
packages/core/src/resource/api.ts
Outdated
| @@ -66,7 +66,7 @@ export enum ResourceStatus { | |||
| */ | |||
| export interface Resource<T> { | |||
| /** | |||
| * The current value of the `Resource`, or `undefined` if there is no current value. | |||
| * The current value of the `Resource`, or throws an error if there is no current value. | |||
There was a problem hiding this comment.
Suggested change
| * The current value of the `Resource`, or throws an error if there is no current value. | |
| * The current value of the `Resource`, or throws an error if the resource is in an error state. |
packages/core/src/resource/api.ts
Outdated
| @@ -186,8 +186,8 @@ export interface BaseResourceOptions<T, R> { | |||
| request?: () => R; | |||
|
|
|||
| /** | |||
| * The value which will be returned from the resource when a server value is unavailable, such as | |||
| * when the resource is still loading, or in an error state. | |||
| * The value which will be returned from the resource when a server value is unavailable and | |||
There was a problem hiding this comment.
Suggested change
| * The value which will be returned from the resource when a server value is unavailable and | |
| * The value which will be returned from the resource when a server value is unavailable, such as | |
| * when the resource is still loading. |
e652c69 to
c186fde
Compare
…efined When there is an underlying error state it would not be possible to swallow the error with: `computed(() => res.value()?.inner);`
c186fde to
3102ba7
Compare
|
Close in favour of #60610 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is an underlying error state it would not be possible to swallow the error with: