Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(compiler): incorrect spans for template literals #60323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(compiler): incorrect spans for template literals #60323

wants to merge 1 commit into from

Conversation

crisbeto
Copy link
Member

Fixes that we were producing zero-length spans for template literals and template literal elements.

Fixes #60320.
Fixes #60319.

@crisbeto
fix(compiler): incorrect spans for template literals
8d99926 
Fixes that we were producing zero-length spans for template literals and template literal elements.

Fixes angular#60320.
Fixes angular#60319.
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Mar 11, 2025
@crisbeto crisbeto requested a review from devversion March 11, 2025 16:18
@angular-robot angular-robot bot added the area: compiler Issues related to `ngc`, Angular's template compiler label Mar 11, 2025
@ngbot ngbot bot added this to the Backlog milestone Mar 11, 2025
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release and removed action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Mar 11, 2025
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit ef1fd13.

The changes were merged into the following branches: main

@crisbeto crisbeto mentioned this pull request Mar 11, 2025
Closed
crisbeto added a commit to crisbeto/angular that referenced this pull request Mar 11, 2025
@crisbeto
fix(compiler): incorrect spans for template literals (angular#60323)
e667a6f 
Fixes that we were producing zero-length spans for template literals and template literal elements.

Fixes angular#60320.
Fixes angular#60319.

PR Close angular#60323
AndrewKushnir pushed a commit that referenced this pull request Mar 11, 2025
@crisbeto @AndrewKushnir
fix(compiler): incorrect spans for template literals (#60323) (#60331)
56b551d 
Fixes that we were producing zero-length spans for template literals and template literal elements.

Fixes #60320.
Fixes #60319.

PR Close #60323

PR Close #60331
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler target: major This PR is targeted for the next major release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

Wrong location information in TemplateLiteralElement Wrong location information when parsing TemplateLiteral
3 participants
@crisbeto @AndrewKushnir @devversion